Add type check on if-expr #3306
Open
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
approved these changes
Dec 18, 2024
philberty
force-pushed
the
if-mismatch-error
branch
from
dd05fff to
ec71cb1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
philberty
force-pushed
the
if-mismatch-error
branch
from
ec71cb1 to
4786b64
Compare
philberty
requested changes
Jan 10, 2025
CohenArthur
force-pushed
the
if-mismatch-error
branch
from
4786b64 to
557f32b
Compare
philberty
reviewed
Feb 4, 2025
| ok = context->lookup_builtin ("()", &null_ty); | ||
| rust_assert (ok); | ||
|
|
||
| coercion_site (expr.get_mappings ().get_hirid (), |
There was a problem hiding this comment.
What happens if you use the result of this coercion_site? so it becomes:
infered = coercion_site (...)
There was a problem hiding this comment.
Right, that actually makes a lot of sense - sorry I skipped over this. Trying it now
philberty
reviewed
Feb 4, 2025
Check if an if-expr returns void type or a coercible type like an early return. gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Add check on if-expr. gcc/testsuite/ChangeLog: * rust/compile/implicit_returns_err3.rs: Change test to be valid. * rust/compile/torture/if.rs: Likewise. * rust/compile/if-without-else.rs: New test. Signed-off-by: Benjamin Thos <[email protected]>
CohenArthur
force-pushed
the
if-mismatch-error
branch
from
557f32b to
35bd75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if an if-expr return void type.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
Fixes: #3230