Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor this to use the implicit insert #3395

Open
philberty opened this issue Jan 29, 2025 · 0 comments
Open

Refactor this to use the implicit insert #3395

philberty opened this issue Jan 29, 2025 · 0 comments
Labels
cleanup good-first-pr

Comments

@philberty
Copy link
Member

philberty commented Jan 29, 2025 •
edited
Loading

We are calling insert type using the node mappings helper but this should be calling insert_implicit_type so we just pass the hirid through which is much cleaner

gccrs/gcc/rust/typecheck/rust-substitution-mapper.cc

Line 156 in 3c21102

Analysis::NodeMapping (0, 0, mapper.resolved->get_ty_ref (), 0),

gccrs/gcc/rust/typecheck/rust-substitution-mapper.cc

Line 163 in 3c21102

context->insert_type (Analysis::NodeMapping (0, 0,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good-first-pr
Projects
Project Pineapple
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philberty