Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused interfaces #3397

Open
philberty opened this issue Jan 29, 2025 · 1 comment
Open

Remove unused interfaces #3397

philberty opened this issue Jan 29, 2025 · 1 comment
Labels
cleanup good-first-pr

Comments

@philberty
Copy link
Member

We can remove:

https://github.com/Rust-GCC/gccrs/blob/3c21102b7378b9a4d61c36689063f6104e751ff6/gcc/rust/typecheck/rust-typecheck-context.cc#L129C19-L129C41

and

gccrs/gcc/rust/typecheck/rust-typecheck-context.cc

Line 136 in 3c21102

TypeCheckContext::lookup_type_by_node_id (NodeId ref, HirId *id)

these shouldnt really be used and if they are lets talk about it.
@powerboat9
Copy link
Collaborator

Yeah, it does seem like everything being typechecked should use HIR ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good-first-pr
Projects
Project Pineapple
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philberty @powerboat9