Skip to content

Add SDL_RenderGeometry functionality #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SynchroTuner opened this issue Dec 16, 2021 · 2 comments · Fixed by #1472 · May be fixed by #1216
Closed

Add SDL_RenderGeometry functionality #1180

SynchroTuner opened this issue Dec 16, 2021 · 2 comments · Fixed by #1472 · May be fixed by #1216

Comments

@SynchroTuner
Copy link

Hello. SDL_RenderGeometry is added to rendering functionalities in SDL 2.0.18. It can render arbitrary triangle list directly within one call. Are there any plans to add such method to sdl2::render::Canvas?

The method signature may be pub fn geometry(&mut self, texture: &Texture<'_>, vertices: &[Vertex], indices: Option<&[u32]>), and the type Vertex is a wrapper of SDL_Vertex.

@kellerkindt
Copy link
Contributor

Thankfully @moralrecordings has already a WIP implementation that works #1216

@Des-Nerger
Copy link

Des-Nerger commented Dec 31, 2023

This functionality is so important for proper texturing in affine space (allowing for things like the smooth skinning in the 2D skeletal animation), why does the upstream wait for so long to accept the @moralrecordings's changes. I have no clue. I thought with v0.36.0 it'd be there.

@antonilol antonilol linked a pull request Mar 18, 2025 that will close this issue
@antonilol antonilol linked a pull request Mar 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants