Skip to content

Commit a682821

Browse files
rostedthtejun
authored andcommitted
workqueue: Removed double allocation of wq_update_pod_attrs_buf
First commit 2930155 ("workqueue: Initialize unbound CPU pods later in the boot") added the initialization of wq_update_pod_attrs_buf to workqueue_init_early(), and then latter on, commit 84193c0 ("workqueue: Generalize unbound CPU pods") added it as well. This appeared in a kmemleak run where the second allocation made the first allocation leak. Fixes: 84193c0 ("workqueue: Generalize unbound CPU pods") Signed-off-by: Steven Rostedt (Google) <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent ce9ecca commit a682821

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

kernel/workqueue.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6535,9 +6535,6 @@ void __init workqueue_init_early(void)
65356535

65366536
BUG_ON(!zalloc_cpumask_var_node(&pt->pod_cpus[0], GFP_KERNEL, NUMA_NO_NODE));
65376537

6538-
wq_update_pod_attrs_buf = alloc_workqueue_attrs();
6539-
BUG_ON(!wq_update_pod_attrs_buf);
6540-
65416538
pt->nr_pods = 1;
65426539
cpumask_copy(pt->pod_cpus[0], cpu_possible_mask);
65436540
pt->pod_node[0] = NUMA_NO_NODE;

0 commit comments

Comments
 (0)