You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
process_response calls is_valid, which calls validate_sign. However the method validate_sign is invoked with the flag validatecert=False. This means that expired or tampered certificates won't be flagged as invalid.
It would be beneficial to introduce a configuration parameter that allows enforcing certificate validation for the IdP signing certificate. This would help users avoid mistakenly assuming that process_response performs certificate validation.
The text was updated successfully, but these errors were encountered:
When calling the method
process_response
frompython-saml/src/onelogin/saml2/auth.py
, I've noticed that the IdP signing certificate is not validated.process_response
callsis_valid
, which callsvalidate_sign
. However the methodvalidate_sign
is invoked with the flagvalidatecert=False
. This means that expired or tampered certificates won't be flagged as invalid.It would be beneficial to introduce a configuration parameter that allows enforcing certificate validation for the IdP signing certificate. This would help users avoid mistakenly assuming that
process_response
performs certificate validation.The text was updated successfully, but these errors were encountered: