Skip to content

Commit 0378b77

Browse files
committed
[INTERNAL] Add tests for cyclic dependency handling
1 parent 595936d commit 0378b77

File tree

36 files changed

+463
-1
lines changed

36 files changed

+463
-1
lines changed

lib/translators/npm.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class NpmTranslator {
5252
}
5353
}
5454
// When UI5-dependencies are defined, we don't care whether an npm dependency is optional or not.
55-
// All UI5-dependendies need to be there.
55+
// All UI5-dependencies need to be there.
5656
dependencies = Object.assign({}, dependencies, optDependencies);
5757
optDependencies = {};
5858

test/fixtures/cyclic-deps/node_modules/application.cycle.a/package.json

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.a/ui5.yaml

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.a/webapp/index.html

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.a/webapp/test.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.b/package.json

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.b/ui5.yaml

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.b/webapp/index.html

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.b/webapp/test.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/cyclic-deps/node_modules/application.cycle.c/package.json

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)