projectGraphBuilder: Wait for async resolution of optional dependencies

RandomByte · RandomByte · commit 474f931b7620 · 2021-03-12T13:28:48.000+01:00
diff --git a/lib/graph/projectGraphBuilder.js b/lib/graph/projectGraphBuilder.js
@@ -217,7 +217,7 @@ module.exports = async function(nodeProvider) {
 				if (projectGraph.getProject(projectName)) {
 					log.verbose(
 						`Project ${projectName} has already been added to the graph. ` +
-						`Skipping repeated dependency resolution..`);
+						`Skipping dependency resolution...`);
 					skipDependencies = true;
 				} else {
 					projectGraph.addProject(project);
@@ -295,7 +295,7 @@ module.exports = async function(nodeProvider) {
 			}
 		}
 	}
-	projectGraph.resolveOptionalDependencies();
+	await projectGraph.resolveOptionalDependencies();
 
 	return projectGraph;
 };

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ module.exports = async function(nodeProvider) {`
`217`	`217`	`if (projectGraph.getProject(projectName)) {`
`218`	`218`	`log.verbose(`
`219`	`219`	`Project ${projectName} has already been added to the graph. ` +
`220`		- `Skipping repeated dependency resolution..`);
	`220`	+ `Skipping dependency resolution...`);
`221`	`221`	`skipDependencies = true;`
`222`	`222`	`} else {`
`223`	`223`	`projectGraph.addProject(project);`
`@@ -295,7 +295,7 @@ module.exports = async function(nodeProvider) {`
`295`	`295`	`}`
`296`	`296`	`}`
`297`	`297`	`}`
`298`		`- projectGraph.resolveOptionalDependencies();`
	`298`	`+ await projectGraph.resolveOptionalDependencies();`
`299`	`299`
`300`	`300`	`return projectGraph;`
`301`	`301`	`};`