Skip to content

Commit c5b264e

Browse files
committed
projectGraphBuilder: Fix check for already qualified application projects
If the already qualified project is visited again, it should not be skipped but handled like any other duplicate. This change is mainly to prevent the irritating log message indicating that the same project already qualified as the application project but is ignored.
1 parent 43f27c9 commit c5b264e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/graph/ProjectGraph.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class ProjectGraph {
6060
throw new Error(
6161
`Failed to add project ${projectName} to graph: Project name must not be integer-like`);
6262
}
63+
log.verbose(`Adding project: ${projectName}`);
6364
this._projects[projectName] = project;
6465
this._adjList[projectName] = [];
6566
this._optAdjList[projectName] = [];

lib/graph/projectGraphBuilder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,12 +199,12 @@ module.exports = async function(nodeProvider) {
199199
if (!qualifiedApplicationProject) {
200200
log.verbose(`Project ${projectName} qualified as application project for project graph`);
201201
qualifiedApplicationProject = project;
202-
} else if (!(qualifiedApplicationProject.getName() === projectName && node.deduped)) {
202+
} else if (qualifiedApplicationProject.getName() !== projectName) {
203203
// Project is not a duplicate of an already qualified project (which should
204204
// still be processed below), but a unique, additional application project
205205

206206
// TODO: Should this rather be a verbose logging?
207-
// projectPreprocessor handled this like any project that got ignored for some reason and did a
207+
// projectPreprocessor handled this like any project that got ignored and did a
208208
// (in this case misleading) general verbose logging:
209209
// "Ignoring project with missing configuration"
210210
log.info(

0 commit comments

Comments
 (0)