Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random phasings 0:2pi #200

Closed
ryancoe opened this issue Nov 12, 2020 · 0 comments · Fixed by #202
Closed

random phasings 0:2pi #200

ryancoe opened this issue Nov 12, 2020 · 0 comments · Fixed by #202
Assignees
@H0R5E
Labels
bug Something isn't working

Comments

@ryancoe
Copy link
Member

ryancoe commented Nov 12, 2020

We currently create random phasing as ph = rand(..), which will range 0:1, should be 0:2*pi.

Examples of problem in WaveBot, also need to fix in RM3

https://github.com/SNL-WaterPower/WecOptTool/blob/be7f353ab79bfc7bfe58a62d1692d1caf145b58d/examples/WaveBot/simulateDevice.m#L86

https://github.com/SNL-WaterPower/WecOptTool/blob/be7f353ab79bfc7bfe58a62d1692d1caf145b58d/examples/WaveBot/simulateDevice.m#L229
@ryancoe ryancoe added the bug Something isn't working label Nov 12, 2020
@H0R5E H0R5E self-assigned this Nov 12, 2020
@H0R5E H0R5E mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@H0R5E H0R5E

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure random phases are selected from range [0, 2pi] H0R5E/WecOptTool-MATLAB
2 participants
@H0R5E @ryancoe