-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WecOptTool Flow Chart #96
Comments
I don't hate this... :) |
This is a duplicate of. #76 |
@H0R5E |
@H0R5E Okay, I have iterated the chart with a sideways rotation, added what the kids are calling "swimlanes", and a little color. I am looking to see if we can generally agree on this implementation still and therefore seeking high-level feedback (I know not everything is perfectly aligned). Specifically And of course any other general/high-level feedback. |
@ssolson - Kudos on this, I think it is looking very nice!
It is hard to tell that the optimization routine can adjust both geometry and PTO (but not kinematics) |
Sterling, I like it. Personally, I think I would reflect it in the horizontal axis (i.e. flip the locations of the objective function and controller / seastates, etc) to get a clockwise control flow again. Secondly, regarding the lines, you might consider having two types - one for data flow and one for control flow - so that the order of operations is clearer, but it's not a deal breaker. |
Okay, a quick iteration to get the Geometry & PTO in the top left and make the flow of the chart clockwise. Lines are all black now although they look too thick so I will decrease that. Mat and I had a discussion about showing that the optimization routine is interacting with /calling the solvers. To me, this is implicit in the way the lines connect and I think the line would add more clutter than clarity. However, it is worth discussing on if we want to include in the paper or not. Lastly, Mat and I discussed changing the boxes to delineate between inputs and processes. @ryancoe let me know what you think. This is probably ready for another external review e.g. Jesse. |
Yeah, definitely better going clockwise. |
Wouldn’t the optimization routine qualify as a solver? |
A couple of clean-ups to the figure. |
@ssolson - please post final PDF and source here. Also add a SVG to replace the diagram here: https://snl-waterpower.github.io/WecOptTool/user/example.html |
Zip contains final Visio file, PDF, and SVG. GItHub does not allow Visio |
I took an hour to recreate the important aspects of the WecOptTool flow chart in LaTex Tikz. I didn't finish but I wanted to see if Ryan hated it enough to tell me to stop anyway.
Edit link is here: https://www.overleaf.com/8641328196bhrsbhbfmbrr
The text was updated successfully, but these errors were encountered: