Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WecOptTool Flow Chart #96

Closed
ssolson opened this issue Mar 30, 2020 · 14 comments · Fixed by #158
Closed

WecOptTool Flow Chart #96

ssolson opened this issue Mar 30, 2020 · 14 comments · Fixed by #158
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@ssolson
Copy link
Collaborator

ssolson commented Mar 30, 2020

I took an hour to recreate the important aspects of the WecOptTool flow chart in LaTex Tikz. I didn't finish but I wanted to see if Ryan hated it enough to tell me to stop anyway.

Edit link is here: https://www.overleaf.com/8641328196bhrsbhbfmbrr

@ssolson ssolson added the documentation Improvements or additions to documentation label Mar 30, 2020
@ryancoe
Copy link
Member

ryancoe commented Mar 31, 2020

I don't hate this... :)

@ryancoe ryancoe added this to the 0.x milestone Mar 31, 2020
@ssolson
Copy link
Collaborator Author

ssolson commented Mar 31, 2020

This is a duplicate of. #76

@H0R5E H0R5E modified the milestones: 0.x, 0.2 Apr 17, 2020
@ryancoe ryancoe closed this as completed Apr 20, 2020
@ryancoe ryancoe reopened this Apr 20, 2020
@ssolson ssolson self-assigned this Apr 20, 2020
@ssolson
Copy link
Collaborator Author

ssolson commented May 29, 2020

@H0R5E
Ryan & I had a discussion about this for the paper today. Could you take a look for a discussion? This version is trying to walk the line of being useful for both users and laymen. I think we could optimize the layman experience by removing the blocks going into Device, Resource, and controller. And we should probably have one of each e.g. one for the documentation, and one for presentations such as the MEC coming up. Finally, note that once we get close to an agreement I will code it up in Tikz for version control but marked this up in Vizio because its quicker. Feel free to mark up the attached PDF.

image

WecOptTool.pdf

@ssolson
Copy link
Collaborator Author

ssolson commented Jun 4, 2020

@H0R5E Okay, I have iterated the chart with a sideways rotation, added what the kids are calling "swimlanes", and a little color.

I am looking to see if we can generally agree on this implementation still and therefore seeking high-level feedback (I know not everything is perfectly aligned). Specifically
1. Do we like the chart layout?
2. Do we like the amount of detail (e.g. where should there be more or less)?
3. Of the provided details do we like the text I used in the lanes, boxes, and arrows?
4. Do you like that the lanes have color and that the arrow matches the lane color?

And of course any other general/high-level feedback.

image

WecOptTool.pdf

@ryancoe
Copy link
Member

ryancoe commented Jun 5, 2020

@ssolson - Kudos on this, I think it is looking very nice!

  1. Yes, but I would prefer to have the geometry and PTO blocks in the upper left hand corner if possible.
  2. I think this is the right level
  3. Not sure what you're asking
  4. I would have the lines just be black I think..

It is hard to tell that the optimization routine can adjust both geometry and PTO (but not kinematics)

@H0R5E
Copy link
Member

H0R5E commented Jun 5, 2020

Sterling, I like it. Personally, I think I would reflect it in the horizontal axis (i.e. flip the locations of the objective function and controller / seastates, etc) to get a clockwise control flow again. Secondly, regarding the lines, you might consider having two types - one for data flow and one for control flow - so that the order of operations is clearer, but it's not a deal breaker.

@ssolson
Copy link
Collaborator Author

ssolson commented Jun 9, 2020

Okay, a quick iteration to get the Geometry & PTO in the top left and make the flow of the chart clockwise. Lines are all black now although they look too thick so I will decrease that.

Mat and I had a discussion about showing that the optimization routine is interacting with /calling the solvers. To me, this is implicit in the way the lines connect and I think the line would add more clutter than clarity. However, it is worth discussing on if we want to include in the paper or not.

Lastly, Mat and I discussed changing the boxes to delineate between inputs and processes.

@ryancoe let me know what you think. This is probably ready for another external review e.g. Jesse.

image

@H0R5E
Copy link
Member

H0R5E commented Jun 9, 2020

Yeah, definitely better going clockwise.

@ryancoe
Copy link
Member

ryancoe commented Jun 9, 2020

Wouldn’t the optimization routine qualify as a solver?

@ssolson
Copy link
Collaborator Author

ssolson commented Jun 9, 2020

Agreed it is a solver. I also decreased the line thickness.

image

@ssolson
Copy link
Collaborator Author

ssolson commented Jun 9, 2020

Option 2 to help declutter the lines. In this version, the Objective Function and optimization routine have a bi-directional arrow.

I think this creates a very nice clockwise flow to follow.

image

@ssolson
Copy link
Collaborator Author

ssolson commented Jun 18, 2020

A couple of clean-ups to the figure.

image

WecOptToolOriginal.pdf

@ryancoe
Copy link
Member

ryancoe commented Jul 9, 2020

@ssolson - please post final PDF and source here. Also add a SVG to replace the diagram here: https://snl-waterpower.github.io/WecOptTool/user/example.html

@ssolson
Copy link
Collaborator Author

ssolson commented Jul 9, 2020

Zip contains final Visio file, PDF, and SVG. GItHub does not allow Visio

WecOptToolFlowChart.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants