[Refactor] Commit.PreviousCommit

Author: samatstariongroup

SysML2.NET.Serializer.Json/PIM/CommitDeSerializer.cs

@@ -136,26 +136,27 @@ internal static Commit DeSerialize(JsonElement jsonElement, SerializationModeKin
                 logger.LogDebug($"the owningProject Json property was not found in the Commit: {dtoInstance.Id}");
             }
 
-            if (jsonElement.TryGetProperty("previousCommit"u8, out JsonElement previousCommitProjectProperty))
+            if (jsonElement.TryGetProperty("previousCommit"u8, out JsonElement previousCommitProperty))
             {
-                if (previousCommitProjectProperty.ValueKind == JsonValueKind.Null)
+                if (previousCommitProperty.ValueKind == JsonValueKind.Null)
                 {
-                    dtoInstance.PreviousCommits = null;
+                    dtoInstance.PreviousCommit = Guid.Empty;
                 }
                 else
                 {
-                    foreach (var item in previousCommitProjectProperty.EnumerateArray())
+                    if (previousCommitProperty.TryGetProperty("@id"u8, out JsonElement previousCommitPropertyIdProperty))
                     {
-                        if (item.TryGetProperty("@id"u8, out JsonElement itemIdProperty))
+                        var propertyValue = previousCommitPropertyIdProperty.GetString();
+                        if (propertyValue != null)
                         {
-                            dtoInstance.PreviousCommits.Add(itemIdProperty.GetGuid());
+                            dtoInstance.PreviousCommit = Guid.Parse(propertyValue);
                         }
                     }
                 }
             }
             else
             {
-                logger.LogDebug($"the previousCommit Json property was not found in the Commit: {dtoInstance.Id}");
+                logger.LogDebug($"the owningProject Json property was not found in the Commit: {dtoInstance.Id}");
             }
 
             if (jsonElement.TryGetProperty("resourceIdentifier"u8, out JsonElement resourceIdentifierProperty))

SysML2.NET.Serializer.Json/PIM/CommitSerializer.cs

@@ -72,17 +72,9 @@ internal static void Serialize(object obj, Utf8JsonWriter writer, SerializationM
                     writer.WriteString("@id"u8, commit.OwningProject);
                     writer.WriteEndObject();
                     writer.WriteString("resourceIdentifier"u8, commit.ResourceIdentifier);
-                    writer.WriteStartArray("previousCommits"u8);
-                    if (commit.PreviousCommits != null)
-                    {
-                        foreach (var previousCommitId in commit.PreviousCommits)
-                        {
-                            writer.WriteStartObject();
-                            writer.WriteString("@id"u8, previousCommitId);
-                            writer.WriteEndObject();
-                        }
-                    }
-                    writer.WriteEndArray();
+                    writer.WriteStartObject("previousCommit"u8);
+                    writer.WriteString("@id"u8, commit.PreviousCommit);
+                    writer.WriteEndObject();
                     writer.WriteEndObject();
 
                     break;

SysML2.NET/PIM/DTO/Commit.cs

@@ -52,8 +52,8 @@ public class Commit : Record
         public Guid OwningProject { get; set; }
 
         /// <summary>
-        /// Gets or sets the sets the set of immediately preceding <see cref="Commit"/>s
+        /// Gets or sets the immediately preceding <see cref="Commit"/>s
         /// </summary>
-        public List<Guid> PreviousCommits { get; set; } = new List<Guid>();
+        public Guid PreviousCommit { get; set; }
     }
 }