Return response on update_status in all cases #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always return a reply when update/status is queried.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 79.06% 79.16% +0.10%
==========================================
Files 21 21
Lines 1614 1612 -2
==========================================
Hits 1276 1276
+ Misses 338 336 -2 ☔ View full report in Codecov by Sentry. |
ricardobranco777
approved these changes
Nov 30, 2023
sorry I noticed your message after pressing merge 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always return a reply when update/status is queried.
Redirecting the
/update/statusto/instancesin the case that a certain http header is not set is confusing and should not happen. The API path should always return something valid or at least throw an error if a input parameter is missing.