1118 Update of Damping not working with negative coefficients (#1119)

HenrZu · web-flow · commit a1028b592bb9 · 2024-09-03T08:27:47.000+02:00
remove cwiseMax to also update for negative damping coefficients.
diff --git a/cpp/memilio/epidemiology/damping.h b/cpp/memilio/epidemiology/damping.h
@@ -609,8 +609,6 @@ void Dampings<S>::update_active_dampings(
         });
         //remove active with the same type and level and add new one
         get<MatrixIdx>(sum_same_level) += get<MatrixIdx>(damping) - get<MatrixIdx>(active_same_type).get();
-        //avoid negative values due to rounding error if e.g. a previous damping is lifted
-        get<MatrixIdx>(sum_same_level)   = get<MatrixIdx>(sum_same_level).cwiseMax(0.);
         get<MatrixIdx>(active_same_type) = get<MatrixIdx>(damping);
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -609,8 +609,6 @@ void Dampings<S>::update_active_dampings(`
`609`	`609`	`});`
`610`	`610`	`//remove active with the same type and level and add new one`
`611`	`611`	`get<MatrixIdx>(sum_same_level) += get<MatrixIdx>(damping) - get<MatrixIdx>(active_same_type).get();`
`612`		`- //avoid negative values due to rounding error if e.g. a previous damping is lifted`
`613`		`- get<MatrixIdx>(sum_same_level) = get<MatrixIdx>(sum_same_level).cwiseMax(0.);`
`614`	`612`	`get<MatrixIdx>(active_same_type) = get<MatrixIdx>(damping);`
`615`	`613`	`}`
`616`	`614`	`else {`