Skip to content

export_input_data_county_timeseries is too similar to read_input_data_county #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
HenrZu opened this issue May 8, 2024 · 0 comments · Fixed by #1029
Closed
2 tasks done

export_input_data_county_timeseries is too similar to read_input_data_county #1028

HenrZu opened this issue May 8, 2024 · 0 comments · Fixed by #1029
Assignees
@HenrZu
Labels
class::bug Bugs found in the software class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::moderate The priority of this task is moderate.

Comments

@HenrZu
Copy link
Contributor

HenrZu commented May 8, 2024 •
edited
Loading

Bug description

The current code for the function export_input_data_county_timeseries is similar to the functionality in read_input_data_county but are completely independent from each other.
This redundancy also increases the susceptibility to errors, as both codes always have to be adapted.
It would be better when they would share the same functionalities since they work nearly equal.

Version

Linux

To reproduce

Compare both results

Relevant log output

No response

Add any relevant information, e.g. used compiler, screenshots.

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@HenrZu HenrZu added class::bug Bugs found in the software prio::moderate The priority of this task is moderate. loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels May 8, 2024
@HenrZu HenrZu self-assigned this May 8, 2024
@HenrZu HenrZu linked a pull request May 10, 2024 that will close this issue
1028 Reduce export_input_data_county_timeseries #1029
Merged
12 tasks
@HenrZu HenrZu changed the title export_input_data_county_timeseries returns different values than read_input_data_county export_input_data_county_timeseries is too similar to read_input_data_county Jun 25, 2024
@HenrZu HenrZu moved this from Product Backlog to 🏗 Development in MEmilio: Equation-Based-Models Development Jun 26, 2024
@HenrZu HenrZu moved this from 🏗 Development to 👀 Review in MEmilio: Equation-Based-Models Development Jun 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done (Sprint) in MEmilio: Equation-Based-Models Development Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenrZu HenrZu

Labels
class::bug Bugs found in the software class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::moderate The priority of this task is moderate.
Projects
MEmilio: Equation-Based-Models Development
Status: Done (Total)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1028 Reduce export_input_data_county_timeseries SciCompMod/memilio
1 participant
@HenrZu