Skip to content

Streamline code for reading in data in model specific IO files #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
HenrZu opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1163
Open
2 tasks done

Streamline code for reading in data in model specific IO files #1108

HenrZu opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1163
Assignees
@HenrZu
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.

Comments

@HenrZu
Copy link
Contributor

HenrZu commented Aug 15, 2024 •
edited
Loading

Motivation / Current Behaviour

A lot of code used to read data , e.g., read_population_data, is doubled in the parameters_io files for the ODE models. We should add documentation and also make them generic.

Enhancement description

less code would make it easier to maintain.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@HenrZu HenrZu added loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels Aug 15, 2024
@HenrZu HenrZu mentioned this issue Aug 15, 2024
Merged
12 tasks
@HenrZu HenrZu mentioned this issue Nov 13, 2024
Merged
12 tasks
@HenrZu HenrZu linked a pull request Dec 13, 2024 that will close this issue
1108 Streamline code for reading in data in model specific IO files #1163
Open
12 tasks
@HenrZu HenrZu moved this from Product Backlog to 🏗 Development in MEmilio: Equation-Based-Models Development Jan 29, 2025
@HenrZu HenrZu changed the title Reuse more code in Initialization Process of ODE models Reuse more code when read in data in model specific IO files Mar 21, 2025
@HenrZu HenrZu moved this from 🏗 Development to 👀 Review in MEmilio: Equation-Based-Models Development Mar 21, 2025
@jubicker jubicker changed the title Reuse more code when read in data in model specific IO files Streamline code for reading in data in model specific IO files Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenrZu HenrZu

Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.
Projects
MEmilio: Equation-Based-Models Development
Status: 👀 Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1108 Streamline code for reading in data in model specific IO files SciCompMod/memilio
1 participant
@HenrZu