You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling Matrix(sol) on an *DE solution returns a CuMatrix when the states are CuVectors.
This is because Matrix(sol) is implemented using a generic hcat (see snippet below). This is a very obvious and useful thing to do, but would it make more sense as an implementation of convert(AbstractMatrix, sol) rather than Matrix(sol)?
I know constructors are not guaranteed to return the invoked type, but it's confusing that you have to call Matrix(Matrix(sol)) to actually get a Matrix.
Calling
Matrix(sol)
on an *DE solution returns aCuMatrix
when the states areCuVector
s.This is because
Matrix(sol)
is implemented using a generichcat
(see snippet below). This is a very obvious and useful thing to do, but would it make more sense as an implementation ofconvert(AbstractMatrix, sol)
rather thanMatrix(sol)
?I know constructors are not guaranteed to return the invoked type, but it's confusing that you have to call
Matrix(Matrix(sol))
to actually get aMatrix
.RecursiveArrayTools.jl/src/vector_of_array.jl
Lines 90 to 95 in d06ecb8
The text was updated successfully, but these errors were encountered: