Merge pull request #1224 from yileicn/master

yileicn · web-flow · commit 5f2083f5c16b · 2025-11-20T14:16:29.000+08:00
hotfix HttpContext NullReferenceException
diff --git a/src/Plugins/BotSharp.Plugin.ChatHub/SignalRHub.cs b/src/Plugins/BotSharp.Plugin.ChatHub/SignalRHub.cs
@@ -28,7 +28,8 @@ public override async Task OnConnectedAsync()
         _logger.LogInformation($"SignalR Hub: {_user.FirstName} {_user.LastName} ({Context.User.Identity.Name}) connected in {Context.ConnectionId}");
 
         var convService = _services.GetRequiredService<IConversationService>();
-        _context.HttpContext.Request.Query.TryGetValue("conversation-id", out var conversationId);
+        var httpContext = Context.GetHttpContext();
+        string? conversationId = httpContext?.Request?.Query["conversation-id"].FirstOrDefault();
 
         if (!string.IsNullOrEmpty(conversationId))
         {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ public override async Task OnConnectedAsync()`
`28`	`28`	`_logger.LogInformation($"SignalR Hub: {_user.FirstName} {_user.LastName} ({Context.User.Identity.Name}) connected in {Context.ConnectionId}");`
`29`	`29`
`30`	`30`	`var convService = _services.GetRequiredService<IConversationService>();`
`31`		`- _context.HttpContext.Request.Query.TryGetValue("conversation-id", out var conversationId);`
	`31`	`+ var httpContext = Context.GetHttpContext();`
	`32`	`+ string? conversationId = httpContext?.Request?.Query["conversation-id"].FirstOrDefault();`
`32`	`33`
`33`	`34`	`if (!string.IsNullOrEmpty(conversationId))`
`34`	`35`	`{`