[MS] Hide and unmount workspace from contextual menu #11686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
4 times, most recently
from
aa83f70 to
7f15eab
Compare
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
2 times, most recently
from
9f1235f to
126d6ce
Compare
mmmarcos
reviewed
Nov 20, 2025
fabienSvtr
changed the base branch from
master
to
ms-show-hide-workspace-feature
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
126d6ce to
d9d85e2
Compare
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
2 times, most recently
from
182dc53 to
4c81f85
Compare
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
87eb970 to
32f7704
Compare
Max-7
requested changes
Nov 24, 2025
client/src/views/workspaces/SmallDisplayWorkspaceContextMenu.vue
Outdated
Show resolved
Hide resolved
| <ion-item | ||
| button | ||
| v-show="clientProfile !== UserProfile.Outsider && isDesktop() && isHidden" | ||
| @click="onClick(WorkspaceAction.UnMount)" |
Contributor
There was a problem hiding this comment.
If the workspace is hidden you're unmounting?
Contributor
Author
There was a problem hiding this comment.
Yes that's the point of the issue
Contributor
There was a problem hiding this comment.
Check your code, or just try it in small display.
fabienSvtr
force-pushed
the
ms-show-hide-workspace-feature
branch
from
5e9431f to
6f31624
Compare
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
02e767d to
9cfc0f6
Compare
Max-7
requested changes
Nov 25, 2025
| <ion-item | ||
| button | ||
| v-show="clientProfile !== UserProfile.Outsider && isDesktop() && isHidden" | ||
| @click="onClick(WorkspaceAction.UnMount)" |
Contributor
There was a problem hiding this comment.
Check your code, or just try it in small display.
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
f7b0118 to
22b81cd
Compare
fabienSvtr
force-pushed
the
ms-show-hide-workspace-feature
branch
2 times, most recently
from
b1fc131 to
c91e254
Compare
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
22b81cd to
893b335
Compare
fabienSvtr
force-pushed
the
ms-show-hide-workspace-feature
branch
from
c91e254 to
5c30a06
Compare
added 2 commits
December 8, 2025 10:01
…t" based on workspace hidden state
fabienSvtr
force-pushed
the
ms-hide-and-unmount-workspace
branch
from
893b335 to
24c91a2
Compare
fabienSvtr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what's changed
The user can open workspace context menu to hide/unhide "Mount" and "Unmount" based on workspace hidden state
Show.Hide.mov
closes #11865