[Bug] shortcuts target directly appended to the $dir

[kengwang]

Bug Report

Scenario

I'm trying to add a jar executable shortcut by this manifest

"shortcuts": [
        [
            "java", // consume there is java on the machine
            "App",
            "-jar \"$dir/app.jar\""
        ]
    ]

Current Behavior

target just directly appended to $dir

Scoop/lib/shortcuts.ps1

Line 5 in 859d1db

$target = [System.IO.Path]::Combine($dir, $_.item(0))

Expected Behavior

It should find where the target is just like where the shim creation does.

Scoop/lib/install.ps1

Lines 752 to 759 in 859d1db

	if (Test-Path "$dir\$target" -PathType leaf) {
	$bin = "$dir\$target"
	} elseif (Test-Path $target -PathType leaf) {
	$bin = $target
	} else {
	$bin = (Get-Command $target).Source
	}
	if (!$bin) { abort "Can't shim '$target': File doesn't exist." }

Possible Solution

It should try to find where the target is and create the link to that.

Please note that the link's working directory just simply reads the $target 's directory, it should be changed to $dir by passing it down.

System details

Windows version: 11

OS architecture: 64bit

PowerShell version: 7.4.6