Skip to content

Commit 40b6f47

Browse files
committed
Addressed comments by Anant
1 parent 95d4186 commit 40b6f47

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

presto-main/src/main/java/com/facebook/presto/cost/ScalarStatsCalculator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,14 +117,14 @@ private class RowExpressionStatsVisitor
117117
private final PlanNodeStatsEstimate input;
118118
private final ConnectorSession session;
119119
private final FunctionResolution resolution = new FunctionResolution(metadata.getFunctionAndTypeManager().getFunctionAndTypeResolver());
120-
private final boolean isStatsPropagationEnabled;
120+
private final boolean isScalarFunctionStatsPropagationEnabled;
121121

122122
public RowExpressionStatsVisitor(PlanNodeStatsEstimate input, ConnectorSession session)
123123
{
124124
this.input = requireNonNull(input, "input is null");
125125
this.session = requireNonNull(session, "session is null");
126126
// casting session to FullConnectorSession is not ideal.
127-
this.isStatsPropagationEnabled =
127+
this.isScalarFunctionStatsPropagationEnabled =
128128
SystemSessionProperties.shouldEnableScalarFunctionStatsPropagation(((FullConnectorSession) session).getSession());
129129
}
130130

@@ -216,7 +216,7 @@ public VariableStatsEstimate visitSpecialForm(SpecialFormExpression specialForm,
216216

217217
private VariableStatsEstimate computeStatsViaAnnotations(CallExpression call, Void context, FunctionMetadata functionMetadata)
218218
{
219-
if (isStatsPropagationEnabled) {
219+
if (isScalarFunctionStatsPropagationEnabled) {
220220
if (functionMetadata.hasStatsHeader() && call.getFunctionHandle() instanceof BuiltInFunctionHandle) {
221221
Signature signature = ((BuiltInFunctionHandle) call.getFunctionHandle()).getSignature().canonicalization();
222222
Optional<ScalarStatsHeader> statsHeader = functionMetadata.getScalarStatsHeader(signature);

presto-main/src/test/java/com/facebook/presto/cost/TestScalarStatsCalculator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -917,6 +917,7 @@ public static long customPrng(
917917
return (long) ((Math.random() * (max - min)) + min);
918918
}
919919

920+
// Following functions are annotated with incorrect Stats annotation to cover -ve or boundary conditions.
920921
@ScalarFunction(value = "custom_is_null2", calledOnNullInput = true)
921922
@SqlType(StandardTypes.BOOLEAN)
922923
@ScalarFunctionConstantStats(distinctValuesCount = -3.19, nullFraction = 0.0)

0 commit comments

Comments
 (0)