Skip to content

Commit d8b8727

Browse files
author
Adrian Muntean
committed
Return empty string in case of None
1 parent a0ca977 commit d8b8727

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

localized_fields/value.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,4 +233,4 @@ def __str__(self) -> str:
233233
"""Returns string representation of value"""
234234

235235
value = self.translate()
236-
return str(value) if value is not None else None
236+
return str(value) if value is not None else ''

localized_fields/widgets.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from django import forms
77
from django.contrib.admin import widgets
88

9-
from .value import LocalizedValue, LocalizedIntegerValue
9+
from .value import LocalizedValue
1010

1111

1212
class LocalizedFieldWidget(forms.MultiWidget):
@@ -52,7 +52,6 @@ def decompress(self, value: LocalizedValue) -> List[str]:
5252
return result
5353

5454
def get_context(self, name, value, attrs):
55-
value = self.remove_if_needed(value)
5655
context = super(forms.MultiWidget, self).get_context(name, value, attrs)
5756
if self.is_localized:
5857
for widget in self.widgets:
@@ -99,16 +98,6 @@ def build_widget_attrs(widget, value, attrs):
9998

10099
return attrs
101100

102-
@staticmethod
103-
def remove_if_needed(value):
104-
"""If the field LocalizedIntegerField is null in the DB then it must
105-
be set to None so it can be represented"""
106-
if isinstance(value, LocalizedIntegerValue):
107-
not_none_score = list(filter(lambda x: value[x] is not None, [i[0] for i in settings.LANGUAGES]))
108-
return value if len(not_none_score) > 0 else None
109-
else:
110-
return value
111-
112101

113102
class LocalizedCharFieldWidget(LocalizedFieldWidget):
114103
"""Widget that has an input box for every language."""

0 commit comments

Comments
 (0)