Skip to content

Commit 5bbad71

Browse files
authored
docs: update CODE_REVIEWS.md bullet formatting (angular#28123)
Update bulleted points in CODE_REVIEWS.md to remove '.' at the end of each point to be cohesive with the CONTRIBUTING.md guidelines.
1 parent 13629b0 commit 5bbad71

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

CODE_REVIEWS.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# Code reviews for Angular Material
22

3-
* Before any coding begins on new, large, or breaking work, a design discussion should take place.
4-
* All code changes require a review and approval.
5-
* All behaviors should be covered by unit tests in the same PR.
6-
* Large changes should be accompanied by corresponding e2e tests in the same PR.
7-
* Authors should attempt to keep PRs to 200 - 300 line changes.
3+
* Before any coding begins on new, large, or breaking work, a design discussion should take place
4+
* All code changes require a review and approval
5+
* All behaviors should be covered by unit tests in the same PR
6+
* Large changes should be accompanied by corresponding e2e tests in the same PR
7+
* Authors should attempt to keep PRs to 200 - 300 line changes
88

99
## Workflow
1010
1. The code author sends a PR for review. This request should include:
11-
* A high-level description of the change being made.
12-
* Links to any relevant issues.
11+
* A high-level description of the change being made
12+
* Links to any relevant issues
1313
* Screenshots (for visual changes or new additions)
1414
2. Reviews provide comments and the author responds / makes changes. Repeat until LGTM.
1515
3. One or more of the reviewers approve the pull request.

0 commit comments

Comments
 (0)