Skip to content

Commit 98f7301

Browse files
authored
build: fix the approve-size-tests script (angular#29538)
The `approve-size-tests` script was broken, because some private Tooling symbols were moved around. Also updates the golden file.
1 parent fd416a3 commit 98f7301

File tree

3 files changed

+21
-24
lines changed

3 files changed

+21
-24
lines changed

goldens/size-test.yaml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
cdk/drag-drop/all-directives: 153026
2-
cdk/drag-drop/basic: 150520
3-
material/autocomplete/without-optgroup: 274252
4-
material/button-toggle/standalone: 188001
5-
material/chips/basic: 260951
6-
material/datepicker/range-picker/without-form-field: 400297
7-
material/expansion/without-accordion: 197979
8-
material/form-field/advanced: 263205
9-
material/form-field/basic: 261635
10-
material/list/nav-list: 218753
11-
material/menu/without-lazy-content: 278141
12-
material/radio/without-group: 199995
13-
material/select/basic: 316667
14-
material/tabs/advanced: 259447
15-
material/tabs/basic: 259301
1+
cdk/drag-drop/all-directives: 170299
2+
cdk/drag-drop/basic: 166324
3+
material/autocomplete/without-optgroup: 223062
4+
material/button-toggle/standalone: 147380
5+
material/chips/basic: 208741
6+
material/datepicker/range-picker/without-form-field: 364729
7+
material/expansion/without-accordion: 154530
8+
material/form-field/advanced: 223916
9+
material/form-field/basic: 222205
10+
material/list/nav-list: 153825
11+
material/menu/without-lazy-content: 221068
12+
material/radio/without-group: 150402
13+
material/select/basic: 269413
14+
material/tabs/advanced: 217500
15+
material/tabs/basic: 217357

integration/size-test/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ esbuild_config(
1313
name = "esbuild_config",
1414
config_file = "esbuild.config.mjs",
1515
deps = [
16-
"@npm//@angular-devkit/build-angular",
16+
"@npm//@angular/build",
1717
"@npm//@angular/compiler-cli",
1818
"@npm//@babel/core",
1919
],

integration/size-test/esbuild.config.mjs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import babel from '@babel/core';
1010
import {createEs2015LinkerPlugin} from '@angular/compiler-cli/linker/babel';
1111
import {ConsoleLogger, NodeJSFileSystem, LogLevel} from '@angular/compiler-cli';
1212
import {GLOBAL_DEFS_FOR_TERSER_WITH_AOT} from '@angular/compiler-cli/private/tooling';
13-
import adjustStaticClassMembersPlugin from '@angular-devkit/build-angular/src/babel/plugins/adjust-static-class-members.js';
14-
import elideAngularMetadataPlugin from '@angular-devkit/build-angular/src/babel/plugins/elide-angular-metadata.js';
15-
import adjustTypeScriptEnumsPlugin from '@angular-devkit/build-angular/src/babel/plugins/adjust-typescript-enums.js';
16-
import pureToplevelFunctionsPlugin from '@angular-devkit/build-angular/src/babel/plugins/pure-toplevel-functions.js';
13+
import ngBuild from '@angular/build/private';
1714
import fs from 'fs';
1815

1916
/** Babel plugin running the Angular linker. */
@@ -35,17 +32,17 @@ const esbuildBabelOptimizePlugin = {
3532
const content = await fs.promises.readFile(filePath, 'utf8');
3633
const plugins = [
3734
linkerBabelPlugin,
38-
adjustStaticClassMembersPlugin,
39-
elideAngularMetadataPlugin,
40-
adjustTypeScriptEnumsPlugin,
35+
ngBuild.adjustStaticMembers,
36+
ngBuild.elideAngularMetadata,
37+
ngBuild.adjustTypeScriptEnums,
4138
];
4239

4340
// All files except for the auto-generated module entry-point are considered side-effect
4441
// free. For these we can add the pure-top level Babel plugin. This matches conceptually
4542
// with what is done in the Angular CLI compilation pipeline, with respect to everything
4643
// in this repo being an official side-effect free APF package.
4744
if (!args.path.includes('autogenerated_module_index.mjs')) {
48-
plugins.push(pureToplevelFunctionsPlugin);
45+
plugins.push(ngBuild.markTopLevelPure);
4946
}
5047

5148
const {code} = await babel.transformAsync(content, {

0 commit comments

Comments
 (0)