Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation in WA differs from the official implementation #304

Open
hysyyds opened this issue Jan 14, 2025 · 0 comments
Open

Evaluation in WA differs from the official implementation #304

hysyyds opened this issue Jan 14, 2025 · 0 comments

Comments

@hysyyds
Copy link

hysyyds commented Jan 14, 2025

Why call the evaluator at every step? In the official implementation, it only evaluates at the final step.

https://github.com/ServiceNow/BrowserGym/blob/ec6b802cd655f2c6a84ebd66a22a4435d8147272/browsergym/webarena/src/browsergym/webarena/task.py#L185C9-L185C11

https://github.com/web-arena-x/webarena/blob/df352854eef255b007110948f6d4f539af039717/run.py#L330

@hysyyds hysyyds closed this as completed Jan 14, 2025
@hysyyds hysyyds reopened this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant