Clean up links from Docker Compose (#536)

* Clean up redundant comment

* Clean up `links` from Docker Compose by calling `backend` directly instead of `host.docker.internal`.

* Clean up indentation

Author: JosephMarinier

docker-compose.yml

@@ -14,17 +14,16 @@ services:
       - "BEHAVIORAL_TESTING"
       - "SIMILARITY"
     volumes:
-    - ./config:/config
-    - ./azimuth_shr:/azimuth_shr
-    - ./cache:/cache
+      - ./config:/config
+      - ./azimuth_shr:/azimuth_shr
+      - ./cache:/cache
   web:
     image: "${REGISTRY}/azimuth-app:${FRONTEND_VERSION}"
     command:
       - node
       - ./server.js
     environment:
       - "PORT=8080"
+      - "REACT_APP_BACKEND_HOSTNAME=backend"
     ports:
       - "8080:8080"
-    links:
-      - backend:host.docker.internal

webapp/server.js

@@ -20,12 +20,10 @@ app.use(cors(corsConfig));
 app.use(
   "/api/local",
   createProxyMiddleware({
-    pathRewrite: {
-      "^/api/[^/]+/": "/", // rewrite path
-    },
-    target: process.env.REACT_APP_BACKEND_PORT
-      ? `http://host.docker.internal:${process.env.REACT_APP_BACKEND_PORT}`
-      : "http://host.docker.internal:8091",
+    pathRewrite: { "^/api/[^/]+/": "/" },
+    target: `http://${
+      process.env.REACT_APP_BACKEND_HOSTNAME || "host.docker.internal"
+    }:${process.env.REACT_APP_BACKEND_PORT || 8091}`,
     changeOrigin: true,
   })
 );