Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-shopify from 2.0.1 to 2.1.0 #41

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 16, 2024

Bumps rubocop-shopify from 2.0.1 to 2.1.0.

Release notes

Sourced from rubocop-shopify's releases.

2.1.0

Thank you for reading our release notes! I'm never sure if folks really check this out. After all, if a tree falls in a forest but it doesn't introduce breaking changes, does it count as a release? Anyway, here's what's new:

  • We now require RuboCop 1.13 and up.
  • Inherit mode is now set to merge configs for inclusions and exclusions. In case you want to completely override exclusions and inclusions, you might need to explicit configure your preferred inherit mode in your RuboCop config file. More info in the PR: #250
  • The Lint/Syntax cop is now enabled. It goes without saying but syntax errors do violate the Style Guide! (PR #254)
  • We also re-enabled the Layout/BeginEndAlignment cop. It was disabled in the past due to a bug, and now it's back to fix your code blocks! (PR #258)
  • This is a big one: we finally removed the DisabledByDefault: true setting and we disabled all unwanted cops one-by-one. This should not have any consequence for most people using our gem, but in case you are using other RuboCop extensions or your own custom cops, you might notice that now everything comes enabled by default (unless you are disabling them yourself). If you were overriding this setting to false you might also be able to remove it from your RuboCop config file. (PR #220)
  • Last but not least: Style/WordArray and Style/SymbolArray are now enabled and set to enforce the brackets style. This rule was actually introduced back in 2019 to the Style Guide but we did not enforce it with RuboCop. Well, now we do! (and therefore we are not considering this a breaking change). (PR #256)
Commits
  • 7195107 Release version 2.1.0
  • d5ba06b Update RuboCop to 1.13
  • 06447da Merge pull request #256 from marcushwz/add_style_word_array
  • 8f2150f Enable WordArray and SymbolArray with enforced style brackets
  • 8971bff Merge pull request #220 from Shopify/remove-disable-by-default
  • 2cbfcb4 Remove DisabledByDefault
  • 530f999 Merge pull request #253 from Shopify/supported-styles
  • 364c3c3 Merge pull request #258 from Shopify/begin-end-align-start-of-line
  • 0236efd Use Layout/BeginEndAlignment style start_of_line
  • 51b8b78 Merge pull request #257 from Shopify/dependabot/npm_and_yarn/sass-1.32.10
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 16, 2024
Bumps [rubocop-shopify](https://github.com/Shopify/ruby-style-guide) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/Shopify/ruby-style-guide/releases)
- [Commits](Shopify/ruby-style-guide@v2.0.1...v2.1.0)

---
updated-dependencies:
- dependency-name: rubocop-shopify
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-shopify-2.1.0 branch from 9b77367 to 7446f06 Compare May 16, 2024 20:23
@lavoiesl
Copy link
Contributor

Rubocop dropped support for ruby 2.6 and this repo specifically uses it because it's the default ruby installed on macOS

@lavoiesl
Copy link
Contributor

@dependabot ignore this dependency

@dependabot dependabot bot closed this May 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2024

OK, I won't notify you about rubocop-shopify again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/bundler/rubocop-shopify-2.1.0 branch May 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant