Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning a reference to a temporary #2911

Open
1 task
elan opened this issue Jan 24, 2025 · 0 comments
Open
1 task

Returning a reference to a temporary #2911

elan opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@elan
Copy link

elan commented Jan 24, 2025

Description

Noticed this while browsing:

https://github.com/Shopify/react-native-skia/blob/main/packages/skia/cpp/jsi/JsiValue.cpp#L58

React Native Skia Version

master

React Native Version

0.76

Using New Architecture

  • Enabled

Steps to Reproduce

It's just a warning, but it's undefined behavior.

Snack, Code Example, Screenshot, or Link to Repository

https://github.com/Shopify/react-native-skia/blob/main/packages/skia/cpp/jsi/JsiValue.cpp#L58

@elan elan added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant