From 513f9e6c3bb6a9f1d289820a9a40602c5ef04d28 Mon Sep 17 00:00:00 2001 From: Paulo Margarido <64600052+paulomarg@users.noreply.github.com> Date: Fri, 5 Apr 2024 09:41:43 -0400 Subject: [PATCH] Fix recurring app charge currency type --- .changeset/young-hotels-agree.md | 5 +++++ .../rest/admin/2022-10/recurring_application_charge.ts | 8 ++------ .../rest/admin/2023-01/recurring_application_charge.ts | 8 ++------ .../rest/admin/2023-04/recurring_application_charge.ts | 8 ++------ .../rest/admin/2023-07/recurring_application_charge.ts | 8 ++------ .../rest/admin/2023-10/recurring_application_charge.ts | 8 ++------ .../rest/admin/2024-01/recurring_application_charge.ts | 8 ++------ .../rest/admin/2024-04/recurring_application_charge.ts | 8 ++------ 8 files changed, 19 insertions(+), 42 deletions(-) create mode 100644 .changeset/young-hotels-agree.md diff --git a/.changeset/young-hotels-agree.md b/.changeset/young-hotels-agree.md new file mode 100644 index 000000000..92ee7d800 --- /dev/null +++ b/.changeset/young-hotels-agree.md @@ -0,0 +1,5 @@ +--- +"@shopify/shopify-api": patch +--- + +Fixed an issue with the `RecurringApplicationCharge` REST resource currency type diff --git a/packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts index 8ba30578b..257b89133 100644 --- a/packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.October22; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts index 5fb87cd0e..75e66a7ac 100644 --- a/packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.January23; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts index 2ef95d502..1eadaa105 100644 --- a/packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.April23; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts index 15a8c2f91..4acac3056 100644 --- a/packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.July23; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts index 30331365d..efc893aa2 100644 --- a/packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.October23; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts index 770bff0c8..cb4e75fa2 100644 --- a/packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.January24; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null; diff --git a/packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts b/packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts index cbe1c17d5..4feef2536 100644 --- a/packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts +++ b/packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts @@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types'; import {Session} from '../../../lib/session/session'; import {ApiVersion} from '../../../lib/types'; -import {Currency} from './currency'; - interface FindArgs { session: Session; id: number | string; @@ -32,9 +30,7 @@ interface CustomizeArgs { export class RecurringApplicationCharge extends Base { public static apiVersion = ApiVersion.April24; - protected static hasOne: {[key: string]: typeof Base} = { - "currency": Currency - }; + protected static hasOne: {[key: string]: typeof Base} = {}; protected static hasMany: {[key: string]: typeof Base} = {}; protected static paths: ResourcePath[] = [ {"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/.json"}, @@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base { public capped_amount: string | number | null; public confirmation_url: string | null; public created_at: string | null; - public currency: Currency | null | {[key: string]: any}; + public currency: string | null; public id: number | null; public name: string | null; public price: string | number | null;