Skip to content

Commit 02f2e1a

Browse files
authored
Merge branch 'main' into add-rest-resource-guide
2 parents 6ec6b4d + dbb3c44 commit 02f2e1a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
Note: For changes to the API, see https://shopify.dev/changelog?filter=api
44
## Unreleased
55

6+
- [#1405](https://github.com/Shopify/shopify-api-ruby/pull/1405) Fix webhook registration for topics containing dots (e.g., `customer.tags_added`, `customer.tags_removed`)
7+
68
## 14.11.1
79

810
- [#1395](https://github.com/Shopify/shopify-api-ruby/pull/1395) use correct internal admin host for 1P app development

lib/shopify_api/webhooks/registration.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Registration
3232
filter: T.nilable(String)).void
3333
end
3434
def initialize(topic:, path:, handler: nil, fields: nil, metafield_namespaces: nil, filter: nil)
35-
@topic = T.let(topic.gsub("/", "_").upcase, String)
35+
@topic = T.let(topic.gsub(%r{/|\.}, "_").upcase, String)
3636
@path = path
3737
@handler = handler
3838
fields_array = fields.is_a?(String) ? fields.split(FIELDS_DELIMITER) : fields

0 commit comments

Comments
 (0)