Skip to content

Fix engine initialization #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizkenyon merged 2 commits into from
Dec 18, 2025
Merged

Fix engine initialization #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d7dfa
Fix engine initialization
kirillplatonov Dec 18, 2025
489cbb7
Update changelog
kirillplatonov Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
Unreleased
----------

- Fix engine initialization [#2040](https://github.com/Shopify/shopify_app/pull/2040)


23.0.0 (December 11, 2025)
----------
- ⚠️ [Breaking] Bumps minimum supported Rails version to 7.1 & Ruby version to 3.2; moves jobs from `lib` to `app` to fix loading issues with modern rails versions. [#2020](https://github.com/Shopify/shopify_app/pull/2020)
- ActiveJob classes moved from `lib/shopify_app/jobs/` to `app/jobs/shopify_app/` to follow Rails conventions and fix timing issues with ActiveJob initialization
- Jobs are now autoloaded by Rails instead of explicitly required during gem initialization
Expand Down
4 changes: 2 additions & 2 deletions lib/shopify_app/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class Engine < Rails::Engine
]
end

initializer "shopify_app.redact_job_params" do
ActiveSupport.on_load(:active_job) do
initializer "shopify_app.redact_job_params" do |app|
app.config.after_initialize do
if ActiveJob::Base.respond_to?(:log_arguments?)
WebhooksManagerJob.log_arguments = false
ScriptTagsManagerJob.log_arguments = false
Expand Down