Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an abstraction layer for databases #2

Open
citorva opened this issue Aug 24, 2019 · 1 comment
Open

Make an abstraction layer for databases #2

citorva opened this issue Aug 24, 2019 · 1 comment
Assignees
Labels
feature Feature for version sielo
Milestone

Comments

@citorva
Copy link
Member

citorva commented Aug 24, 2019

Sielo uses SQLite as a database system. In order to make sielo compatible with last versions and avoid any problem due to database modification, a layer might be implemented. It needs:

  • Check if a table exists and create it else
  • Check if the table has correct field. Otherwise creates missing fields and attempt to fix bad fields.
  • Make an interface between core and database (SQL request must pass through this interface in order to send request)

In order to be flexible with a database, the interface needs to be a trait and implement for each supported database system (SQLite...)

@citorva citorva added the feature Feature for version sielo label Aug 24, 2019
@citorva citorva added this to the Version 0.1 milestone Aug 24, 2019
@citorva citorva self-assigned this Aug 24, 2019
@citorva citorva changed the title Make an abstraction for databases Make an abstraction layer for databases Aug 28, 2019
@citorva
Copy link
Member Author

citorva commented Aug 28, 2019

The pure-implementation is done. It is now necessary to write tests in order to make this code safe and clean up code. It is also necessary to write documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature for version sielo
Projects
None yet
Development

No branches or pull requests

1 participant