Skip to content

[3.0] Issue 8134 #8704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-3.0
Choose a base branch
from
Open

[3.0] Issue 8134 #8704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b57933
Issue 8134
arlomedia Jun 26, 2025
eb64386
Update Sources/Session.php
arlomedia Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Sources/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,6 @@ public function destroy(string $session_id): bool
*/
public function gc(int $max_lifetime): int|false
{
// Just set to the default or lower? Ignore it for a higher value. (hopefully)
if (!empty(Config::$modSettings['databaseSession_lifetime']) && ($max_lifetime <= 1440 || Config::$modSettings['databaseSession_lifetime'] > $max_lifetime)) {
$max_lifetime = max(Config::$modSettings['databaseSession_lifetime'], 60);
}

// Clean up after yerself ;).
$session_update = Db::$db->query(
'DELETE FROM {db_prefix}sessions
Expand Down Expand Up @@ -231,9 +226,8 @@ public static function load(): void
session_set_save_handler(new self(), true);

@ini_set('session.gc_probability', '1');
} elseif (ini_get('session.gc_maxlifetime') <= 1440 && !empty(Config::$modSettings['databaseSession_lifetime'])) {
@ini_set('session.gc_maxlifetime', max(Config::$modSettings['databaseSession_lifetime'], 60));
}
@ini_set('session.gc_maxlifetime', max(Config::$modSettings['databaseSession_lifetime'], 60));

// Use cache setting sessions?
if (empty(Config::$modSettings['databaseSession_enable']) && !empty(CacheApi::$enable) && php_sapi_name() != 'cli') {
Expand Down