FS Namespaces and Implicit Global Usings

Author: JimBobSquarePants

.editorconfig

@@ -253,6 +253,9 @@ csharp_space_between_square_brackets = false
 # https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/formatting-rules#wrap-options
 csharp_preserve_single_line_statements = false
 csharp_preserve_single_line_blocks = true
+# Namespace options
+# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/formatting-rules#namespace-options
+csharp_style_namespace_declarations = file_scoped:warning
 
 ##########################################
 # .NET Naming Rules
@@ -452,4 +455,4 @@ dotnet_naming_rule.parameters_rule.severity             = warning
 # WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 # OTHER DEALINGS IN THE SOFTWARE.
-##########################################
+##########################################

shared-infrastructure

@@ -1,16 +1,15 @@
 // Copyright (c) Six Labors.
 // Licensed under the Six Labors Split License.
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// Defines the contract for objects that can provide access to configuration.
+/// </summary>
+internal interface IConfigurationProvider
 {
     /// <summary>
-    /// Defines the contract for objects that can provide access to configuration.
+    /// Gets the configuration which allows altering default behaviour or extending the library.
     /// </summary>
-    internal interface IConfigurationProvider
-    {
-        /// <summary>
-        /// Gets the configuration which allows altering default behaviour or extending the library.
-        /// </summary>
-        Configuration Configuration { get; }
-    }
+    Configuration Configuration { get; }
 }

src/ImageSharp/Advanced/AdvancedImageExtensions.cs

@@ -1,41 +1,38 @@
 // Copyright (c) Six Labors.
 // Licensed under the Six Labors Split License.
 
-using System.Threading;
-using System.Threading.Tasks;
 using SixLabors.ImageSharp.PixelFormats;
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// A visitor to implement a double-dispatch pattern in order to apply pixel-specific operations
+/// on non-generic <see cref="Image"/> instances.
+/// </summary>
+public interface IImageVisitor
 {
     /// <summary>
-    /// A visitor to implement a double-dispatch pattern in order to apply pixel-specific operations
-    /// on non-generic <see cref="Image"/> instances.
+    /// Provides a pixel-specific implementation for a given operation.
     /// </summary>
-    public interface IImageVisitor
-    {
-        /// <summary>
-        /// Provides a pixel-specific implementation for a given operation.
-        /// </summary>
-        /// <param name="image">The image.</param>
-        /// <typeparam name="TPixel">The pixel type.</typeparam>
-        void Visit<TPixel>(Image<TPixel> image)
-            where TPixel : unmanaged, IPixel<TPixel>;
-    }
+    /// <param name="image">The image.</param>
+    /// <typeparam name="TPixel">The pixel type.</typeparam>
+    void Visit<TPixel>(Image<TPixel> image)
+        where TPixel : unmanaged, IPixel<TPixel>;
+}
 
+/// <summary>
+/// A visitor to implement a double-dispatch pattern in order to apply pixel-specific operations
+/// on non-generic <see cref="Image"/> instances.
+/// </summary>
+public interface IImageVisitorAsync
+{
     /// <summary>
-    /// A visitor to implement a double-dispatch pattern in order to apply pixel-specific operations
-    /// on non-generic <see cref="Image"/> instances.
+    /// Provides a pixel-specific implementation for a given operation.
     /// </summary>
-    public interface IImageVisitorAsync
-    {
-        /// <summary>
-        /// Provides a pixel-specific implementation for a given operation.
-        /// </summary>
-        /// <param name="image">The image.</param>
-        /// <param name="cancellationToken">The token to monitor for cancellation requests.</param>
-        /// <typeparam name="TPixel">The pixel type.</typeparam>
-        /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
-        Task VisitAsync<TPixel>(Image<TPixel> image, CancellationToken cancellationToken)
-            where TPixel : unmanaged, IPixel<TPixel>;
-    }
+    /// <param name="image">The image.</param>
+    /// <param name="cancellationToken">The token to monitor for cancellation requests.</param>
+    /// <typeparam name="TPixel">The pixel type.</typeparam>
+    /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
+    Task VisitAsync<TPixel>(Image<TPixel> image, CancellationToken cancellationToken)
+        where TPixel : unmanaged, IPixel<TPixel>;
 }

src/ImageSharp/Advanced/AotCompilerTools.cs

@@ -4,29 +4,28 @@
 using SixLabors.ImageSharp.Memory;
 using SixLabors.ImageSharp.PixelFormats;
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// Encapsulates the basic properties and methods required to manipulate images.
+/// </summary>
+internal interface IPixelSource
 {
     /// <summary>
-    /// Encapsulates the basic properties and methods required to manipulate images.
+    /// Gets the pixel buffer.
     /// </summary>
-    internal interface IPixelSource
-    {
-        /// <summary>
-        /// Gets the pixel buffer.
-        /// </summary>
-        Buffer2D<byte> PixelBuffer { get; }
-    }
+    Buffer2D<byte> PixelBuffer { get; }
+}
 
+/// <summary>
+/// Encapsulates the basic properties and methods required to manipulate images.
+/// </summary>
+/// <typeparam name="TPixel">The type of the pixel.</typeparam>
+internal interface IPixelSource<TPixel>
+    where TPixel : unmanaged, IPixel<TPixel>
+{
     /// <summary>
-    /// Encapsulates the basic properties and methods required to manipulate images.
+    /// Gets the pixel buffer.
     /// </summary>
-    /// <typeparam name="TPixel">The type of the pixel.</typeparam>
-    internal interface IPixelSource<TPixel>
-        where TPixel : unmanaged, IPixel<TPixel>
-    {
-        /// <summary>
-        /// Gets the pixel buffer.
-        /// </summary>
-        Buffer2D<TPixel> PixelBuffer { get; }
-    }
+    Buffer2D<TPixel> PixelBuffer { get; }
 }

src/ImageSharp/Advanced/IConfigurationProvider.cs

@@ -3,17 +3,16 @@
 
 using SixLabors.ImageSharp.Memory;
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// Defines the contract for an action that operates on a row interval.
+/// </summary>
+public interface IRowIntervalOperation
 {
     /// <summary>
-    /// Defines the contract for an action that operates on a row interval.
+    /// Invokes the method passing the row interval.
     /// </summary>
-    public interface IRowIntervalOperation
-    {
-        /// <summary>
-        /// Invokes the method passing the row interval.
-        /// </summary>
-        /// <param name="rows">The row interval.</param>
-        void Invoke(in RowInterval rows);
-    }
+    /// <param name="rows">The row interval.</param>
+    void Invoke(in RowInterval rows);
 }

src/ImageSharp/Advanced/IImageVisitor.cs

@@ -1,23 +1,21 @@
 // Copyright (c) Six Labors.
 // Licensed under the Six Labors Split License.
 
-using System;
 using SixLabors.ImageSharp.Memory;
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// Defines the contract for an action that operates on a row interval with a temporary buffer.
+/// </summary>
+/// <typeparam name="TBuffer">The type of buffer elements.</typeparam>
+public interface IRowIntervalOperation<TBuffer>
+    where TBuffer : unmanaged
 {
     /// <summary>
-    /// Defines the contract for an action that operates on a row interval with a temporary buffer.
+    /// Invokes the method passing the row interval and a buffer.
     /// </summary>
-    /// <typeparam name="TBuffer">The type of buffer elements.</typeparam>
-    public interface IRowIntervalOperation<TBuffer>
-        where TBuffer : unmanaged
-    {
-        /// <summary>
-        /// Invokes the method passing the row interval and a buffer.
-        /// </summary>
-        /// <param name="rows">The row interval.</param>
-        /// <param name="span">The contiguous region of memory.</param>
-        void Invoke(in RowInterval rows, Span<TBuffer> span);
-    }
+    /// <param name="rows">The row interval.</param>
+    /// <param name="span">The contiguous region of memory.</param>
+    void Invoke(in RowInterval rows, Span<TBuffer> span);
 }

src/ImageSharp/Advanced/IPixelSource.cs

@@ -1,17 +1,16 @@
 // Copyright (c) Six Labors.
 // Licensed under the Six Labors Split License.
 
-namespace SixLabors.ImageSharp.Advanced
+namespace SixLabors.ImageSharp.Advanced;
+
+/// <summary>
+/// Defines the contract for an action that operates on a row.
+/// </summary>
+public interface IRowOperation
 {
     /// <summary>
-    /// Defines the contract for an action that operates on a row.
+    /// Invokes the method passing the row y coordinate.
     /// </summary>
-    public interface IRowOperation
-    {
-        /// <summary>
-        /// Invokes the method passing the row y coordinate.
-        /// </summary>
-        /// <param name="y">The row y coordinate.</param>
-        void Invoke(int y);
-    }
+    /// <param name="y">The row y coordinate.</param>
+    void Invoke(int y);
 }

src/ImageSharp/Advanced/IRowIntervalOperation.cs

@@ -1,22 +1,19 @@
 // Copyright (c) Six Labors.
 // Licensed under the Six Labors Split License.
 
-using System;
+namespace SixLabors.ImageSharp.Advanced;
 
-namespace SixLabors.ImageSharp.Advanced
+/// <summary>
+/// Defines the contract for an action that operates on a row with a temporary buffer.
+/// </summary>
+/// <typeparam name="TBuffer">The type of buffer elements.</typeparam>
+public interface IRowOperation<TBuffer>
+    where TBuffer : unmanaged
 {
     /// <summary>
-    /// Defines the contract for an action that operates on a row with a temporary buffer.
+    /// Invokes the method passing the row and a buffer.
     /// </summary>
-    /// <typeparam name="TBuffer">The type of buffer elements.</typeparam>
-    public interface IRowOperation<TBuffer>
-        where TBuffer : unmanaged
-    {
-        /// <summary>
-        /// Invokes the method passing the row and a buffer.
-        /// </summary>
-        /// <param name="y">The row y coordinate.</param>
-        /// <param name="span">The contiguous region of memory.</param>
-        void Invoke(int y, Span<TBuffer> span);
-    }
+    /// <param name="y">The row y coordinate.</param>
+    /// <param name="span">The contiguous region of memory.</param>
+    void Invoke(int y, Span<TBuffer> span);
 }