Fix the docker gate: absolute paths are platform-dependent, and the smoke test counted nine nodes (#10)

`docker-tests` has been red on main since at least 06:46 today, and on every push
before that, on one assertion:

    AssertionError: absolute path D:/shots/out was rewritten to
                    /tmp/ocio_meta_test_xxxx/D:/shots/out

check_output_folder asserts that resolve_output_folder leaves an absolute path
alone, and offers `D:\shots\out` and `\nas\vfx\out` as the examples. What counts
as absolute is os.path.isabs, which answers per platform: both are absolute on
Windows and ordinary relative names on Linux. So in the container the resolver
was asked about a relative path, correctly joined it to the output directory, and
the test called that a failure. The resolver is right; the examples were not
portable. Now each platform is asked about paths it considers absolute, with the
test asserting isabs on its own example first so this cannot rot silently again.

The smoke test that proves the pack imports under ComfyUI listed nine node
classes. There are eleven: OCIOVAEDecode and OCIOVAEEncode were never added, so
if either failed to register the gate would have said "all 9 OCIO nodes
registered" and passed. Added them, and the count in the three messages is now
len(OCIO_NODE_CLASSES) rather than a literal, so the next node does not need a
docs edit to be covered.

Verified: tools/test_write_metadata.py passes on Windows after the change, and
the posix examples are absolute under posixpath while the Windows ones are not,
which is exactly the container's failure.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: AndreiOrehov

docker/comfyui_client.py

@@ -13,6 +13,7 @@
 OCIO_NODE_CLASSES = [
     "OCIOColorSpace", "OCIOLogConvert", "OCIODisplay", "OCIOCDLTransform",
     "OCIOFileTransform", "OCIOLookTransform", "OCIORead", "OCIOWrite", "OCIOPlayer",
+    "OCIOVAEDecode", "OCIOVAEEncode",
 ]
 
 

docker/roundtrip_test.py

@@ -34,7 +34,7 @@
 import urllib.request
 
 sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
-from comfyui_client import ComfyUIClient          # noqa: E402
+from comfyui_client import ComfyUIClient, OCIO_NODE_CLASSES   # noqa: E402
 from build_workflow import build_graph            # noqa: E402
 import ocio_names                                 # noqa: E402
 import compare_histograms                          # noqa: E402
@@ -102,7 +102,7 @@ def main():
         if not ok:
             print(f"[comfyui] OCIO nodes missing from /object_info: {missing}\n" + tail(SERVER_LOG))
             return 3
-        print("[comfyui] all 9 OCIO nodes registered.")
+        print(f"[comfyui] all {len(OCIO_NODE_CLASSES)} OCIO nodes registered.")
 
         cfg_src = os.environ.get("OCIO") or "(built-in ACES config)"
         names = ocio_names.resolve_names()

docker/run_tests.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # Unit + smoke test entrypoint for the `test` compose service.
 #   1. Run every standalone tools/test_*.py (exit non-zero on any failure).
-#   2. Boot ComfyUI headless and assert all 9 OCIO nodes register (proves the pack imports in ComfyUI).
+#   2. Boot ComfyUI headless and assert every OCIO node registers (proves the pack imports in ComfyUI).
 #   3. Optional: tools/accuracy regression suite when RUN_ACCURACY=1.
 set -uo pipefail
 
@@ -34,7 +34,7 @@ echo "==================== ComfyUI node-registration smoke ===================="
 python - <<'PY'
 import subprocess, sys, os
 sys.path.insert(0, os.path.join(os.environ.get("OCIO_PACK_DIR", "/opt/ComfyUI/custom_nodes/ComfyUI-OCIO"), "docker"))
-from comfyui_client import ComfyUIClient
+from comfyui_client import ComfyUIClient, OCIO_NODE_CLASSES
 comfy = os.environ.get("COMFYUI_DIR", "/opt/ComfyUI")
 log = open("/tmp/comfyui-smoke.log", "wb")
 proc = subprocess.Popen([sys.executable, "main.py", "--cpu", "--port", "8188", "--listen", "127.0.0.1"],
@@ -45,7 +45,7 @@ try:
     c.wait_until_ready(timeout=300)
     ok, missing = c.check_nodes()
     if ok:
-        print("  ok: all 9 OCIO nodes registered in ComfyUI")
+        print(f"  ok: all {len(OCIO_NODE_CLASSES)} OCIO nodes registered in ComfyUI")
     else:
         print(f"  FAILED: missing nodes {missing}")
         rc = 1

tools/test_write_metadata.py

@@ -532,7 +532,16 @@ def check_output_folder(io, tmp):
     assert n(r("$OUTPUT/a/b")) == n(os.path.join(tmp, "a", "b")), "a nested token path did not resolve"
     assert n(r("shot_010")) == n(os.path.join(tmp, "shot_010")), "a plain relative path changed behaviour"
     # An absolute path stays absolute: pointing a Write at a NAS is deliberate, not a mistake to be corrected.
-    for absolute in (os.path.join("D:" + os.sep, "shots", "out"), r"\\nas\vfx\out"):
+    # What counts as absolute is `os.path.isabs`, which answers per platform: a drive letter and a UNC share are
+    # absolute on Windows and plain relative names on Linux. Asking Linux about "D:/shots/out" therefore tests
+    # that the resolver failed to honour something nobody asked it to, which is how this fails in the container
+    # while passing on Windows. Same assertion either way, on paths the running platform calls absolute.
+    if os.name == "nt":
+        absolutes = (os.path.join("D:" + os.sep, "shots", "out"), r"\\nas\vfx\out")
+    else:
+        absolutes = (os.path.join(os.sep, "mnt", "nas", "vfx", "out"), os.path.join(os.sep, "shots", "out"))
+    for absolute in absolutes:
+        assert os.path.isabs(absolute), f"the test's own example {absolute} is not absolute on this platform"
         assert r(absolute) == absolute, f"absolute path {absolute} was rewritten to {r(absolute)}"
     # And the default the node ships with must not be an absolute path in the first place - it is stored in
     # widgets_values, and core SaveVideo / SaveImage embed the whole workflow JSON inside the files they write.