Fix Windows build related to cppzmq

[jcfr]

Looking at CDash associated with both the Stable from 2025-02-16 (see here) and the Preview build from 2025-02-18 (see here), the extension is packaged and available on Linux and macOS but not on Windows.

Windows error are the following:

C:\path\to\SlicerJupyter-build\cppzmq\zmq.hpp(2506,12): error C3646: 'fd': unknown override specifier [C:\path\to\SlicerJupyter-build\xeus-build\xeus.vcxproj] [C:\D\P\S-0-E-b\SlicerJupyter-build\xeus.vcxproj]

(compiling source file '../xeus/src/xdap_tcp_client.cpp')
        C:\D\P\S-0-E-b\SlicerJupyter-build\cppzmq\zmq.hpp(2506,12):
        the template instantiation context (the oldest one first) is
            C:\D\P\S-0-E-b\SlicerJupyter-build\cppzmq\zmq.hpp(2502,41):
            while compiling class template 'zmq::poller_event'
    
C:\path\to\SlicerJupyter-build\cppzmq\zmq.hpp(2506,5): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [C:\path\to\SlicerJupyter-build\xeus-build\xeus.vcxproj] [C:\D\P\S-0-E-b\SlicerJupyter-build\xeus.vcxproj]
    (compiling source file '../xeus/src/xdap_tcp_client.cpp')
    

For more details, see here

[amymmorton]

Hi all, just checking to see if there is any plan to remedy on windows? Thanks!

[lassoan]

I'll try to get to it in the next few weeks. In the meantime, somebody else could attempt a fix, too.

[bpataybac]

Any updates regarding SlicerJupyter extension?

[benbennett]

pretty sure the slicer cppzmq has to be fast-forwarded to newer branch for visual studio 2022 compiler . https://github.com/Slicer/cppzmq if anyone knows what other items this might effect fast-forwarding that would be helpful. I will try to fix this in the next few days. I don't have the environment to test macos builds though. i have forked 3d slicer , slicerjupyter and cppzmq . I think those are all the projects that have to be updated and I will submit the merge request.

Just looking for what else uses cppzmq.

[lassoan]

I agree, probably we just need to update all dependencies to (near) latest versions. It would be great if someone could do it, and I would review and merge.

[benbennett]

Stuck in dependence **** was able to make progress. Note this breaks with the recent python updates on linux too. xeus-python wants pybind11_REQUIRED_VERSION 2.6.1 which I am pretty sure doesn't work with python 3.12. it's in this https://github.com/jupyter-xeus/xeus-python/blob/main/CMakeLists.txt .

[jamesobutler]

@benbennett Upon reviewing https://github.com/jupyter-xeus/xeus-python?tab=readme-ov-file#dependencies it appears xeus-Python has a minimum required version of pybind11 2.6.1, but allows up to any version < 3.

[lassoan]

Yes, the pybind11 package version requirement is not EXACT (see here) so you can use compatible versions, it does not have to be exactly 2.6.1

[benbennett]

I have everything compiling at this point. Clion internal cmake was breaking my configuration. I will push a branch to review by tomorrow . expecting to have to change things to the way things are done properly in this project.

[benbennett]

cmake config options
-G "Visual Studio 17 2022"
-DSlicer_DIR:PATH=C:/D/SR/Slicer-build
-DSlicerJupyter_cppzmq_GIT_REPOSITORY=git@github.com:benbennett/cppzmq.git
-DSlicerJupyter_cppzmq_GIT_TAG=26606ee2e805ca7773bf983f458574543162a3fa

master...benbennett:SlicerJupyter:vs2022fixes

I don't like the requirements thing I did and I have no idea what the copywrite items are for new files should be.
pybind11 v2.13.6 cmake build is broken and I just added a patch to it.

main item I had to break out the xeus into it's own comp unit vtk nlohmann was causing linker errors. ie the module was compiled with vtk nlohmann but xeus was compile with the regular nlohmann so you get an un-resolved linker error.

[benbennett]

can't build in debug current on vs because of this issue https://discourse.vtk.org/t/vtk-9-4-debug-build-fails-with-msvc-due-to-image-size-exceeds-maximum-allowable-size/15520/2

[jamesobutler]

@benbennett That debug build issue has been resolved with Slicer's added support for VTK 9.5 which is using a VTK branch with a fix for that issue. See Slicer/Slicer@fc9e987. I would suggest building with latest Slicer main (currently Slicer/Slicer@c85addc).

[benbennett]

it's running into this error. I briefly looked into it seems that everything is setup in the cmakecache to force to link to the release edition in debug build but the qtcore for some reason still adds the _d to the end. LINK : fatal error LNK1104: cannot open file 'python312_d.lib' [C:\D\SD\Slicer-build\Base\QTCore\qSlicerBaseQTCore.vcxproj] [C:\D\SD\Slicer.vcxproj]

Note everything is working on the windows release build. I am going over to my linux build to make sure everything is building and working.

[jamesobutler]

Yeah you are running into known issue related to debug builds as mentioned at https://discourse.slicer.org/t/build-error-in-windows-in-debug-mode-due-to-python312-d-lib/43781/2.