RPS-6454. Python API SDK stack overflow on parsing error message

Author: anatolija

changes.txt

@@ -1,3 +1,6 @@
+Dec 09, 2022 - 3.1.5
+    - fix of ApiResponse get attribute may cause stack overflow on requesting non-existng attribute
+
 May 24, 2022 - 3.1.4
     - old tests updated to handle 423 errors for FilesAPI
 

smartlingApiSdk/ApiResponse.py

@@ -42,9 +42,9 @@ def __init__(self, responseString, statusCode, headers):
         self.isApiResonse = self.responseDict.get('response', None) and dict == type(self.responseDict['response'])
         self.headers = headers
         if self.isApiResonse:
-            self.parseResponse(responseString)
+            self.parseResponse()
 
-    def parseResponse(self, responseString):
+    def parseResponse(self):
         """ parses json and fills object attributes according json attributes """
 
         for k, v in list(self.responseDict['response'].items()):
@@ -59,9 +59,9 @@ def __getattr__(self, key):
             return getattr(self.responseDict, key)
 
         try:
-            return getattr(self, key)
+            return self.__dict__[key]
         except:
-            pass
+            raise AttributeError("ApiResponse has no attribute %r" % ( key ))
 
     def __str__(self):
         return str(self.responseString)

smartlingApiSdk/version.py

@@ -1,20 +1,20 @@
-#!/usr/bin/python
-# -*- coding: utf-8 -*-
-
-
-""" Copyright 2012-2021 Smartling, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this work except in compliance with the License.
- * You may obtain a copy of the License in the LICENSE file, or at:
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
-"""
-
-version = "3.1.4"
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+
+""" Copyright 2012-2021 Smartling, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this work except in compliance with the License.
+ * You may obtain a copy of the License in the LICENSE file, or at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+"""
+
+version = "3.1.5"

test/test_ApiResponse.py

@@ -48,3 +48,12 @@ def test_ApiResponse_status(self):
         assert_equal(ar.data.fileUri, 'javaUTF16.properties')
         assert_equal(ar.data.completedStringCount, 0)
         assert_equal(ar.data.callbackUrl, 'http://yourdomain.com/callback')
+
+    def test_ApiResponse_failed(self):
+        failed_json = '{"response":{"code":"VALIDATION_ERROR","errors":[{"key":null,"message":"File not found: test_import.xml_2.2.4_1629202583.584802","details":null}]}}'
+        ar = ApiResponse(failed_json, "404", {"Content-Type":"application-json"})
+        try:
+            ua = ar.unexisting
+        except AttributeError as e:
+            assert_equal(str(e), "ApiResponse has no attribute 'unexisting'")
+        assert_equal(ar.code, "VALIDATION_ERROR")