Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running pkgbuild on artix (ffmpeg5) #281

Closed
longboarder241 opened this issue Jun 8, 2022 · 9 comments · Fixed by #285
Closed

Error when running pkgbuild on artix (ffmpeg5) #281

longboarder241 opened this issue Jun 8, 2022 · 9 comments · Fixed by #285
Labels
enhancement New feature or request

Comments

@longboarder241
Copy link

After following the steps for doing a makepkg my install stalls at 74% with this message;
: warning: extra tokens at end of #undef directive
make[2]: *** [src/CMakeFiles/Sneedacity.dir/build.make:173: src/CMakeFiles/Sneedacity.dir/SneedacityApp.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:3001: src/CMakeFiles/Sneedacity.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
==> ERROR: A failure occurred in build().
Aborting...
Any help would be great

@TWilldigg
Copy link

TWilldigg commented Jun 24, 2022

Same issue here. Albiet without the warning: extra tokens. Progress 76% non pkgbuild on arch.
image

@TWilldigg
Copy link

TWilldigg commented Jun 24, 2022

Found an issue in tenacity repo, ffmpeg 5 is the issue, follow the link: https://github.com/tenacityteam/tenacity/issues/705 to fix building.

@Ckath
Copy link
Contributor

Ckath commented Jun 24, 2022

not really a fix to build it on 4.4, its going to have to just be beat into compiling.
I'll try messing with the unmerged pr made to audacity

@TWilldigg
Copy link

Yeah, I have a segfault on the compiled binary any ways, although I have no idea where to start with that.

@Ckath
Copy link
Contributor

Ckath commented Jun 24, 2022

the audacity source and the sneedacity one arent as compatible as they used to anymore with audacity having made the continuous awful effort to move random things into libraries/, was trying to just upgrade all the ffmpeg related parts and slap the pr ontop but its not working out quite as well as I hoped.
the futile effort so far https://github.com/Ckath/sneedacity/tree/ffmpeg5
might look at it again when sober

@Ckath Ckath changed the title Error when running pkgbuild on artix Error when running pkgbuild on artix (ffmpeg5) Jun 25, 2022
@TWilldigg
Copy link

Not entirely sure how audacity is put together/designed, so I'm afraid I can't really help.

@Ckath
Copy link
Contributor

Ckath commented Jun 26, 2022

the gist of it is the same as roughly all issues before it that involved upstream or wild fixes:
the code 'compiles', however due unknown knowledge of how cmake works or how the project builds it fails at linking.
the conan removal stuff stayed at this stage for ages but at that time there were more people with better ideas.
an alternative would be to look into why the current ffmpeg related code cant deal with ffmpeg5 and slowly nudge it towards wanting to compile under ffmpeg5, what I've done currently is just take the audacity code with all the new ffmpeg interaction and try to hammer it into sneedacity which is many codebase redoals behind of it at this point. your messing around with the source until it compiles is going to be as good as mine.

I am not a c++ dev,
I'm not very familiar with cmake,
to this day I have no clear idea of what causes it to build and links the way it does

@Ckath Ckath added enhancement New feature or request help wanted Extra attention is needed labels Jun 26, 2022
@Ckath
Copy link
Contributor

Ckath commented Jun 27, 2022

insult to injury
image

@Ckath
Copy link
Contributor

Ckath commented Jun 27, 2022

got something to compile and link, please see how the pr works out. it at the very least builds and runs on an up to date arch system

@Ckath Ckath removed the help wanted Extra attention is needed label Jul 1, 2022
@Ckath Ckath closed this as completed in #285 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants