[#634] Comment mentions (user tags) #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@marcosschlup my apologies if this was discussed already in Slack, but I have some questions about this feature. When a user is mentioned, are they notified? And should their username be clickable after they've been mentioned in a comment? |
@sterlingrules I didn't touch the notification part. I just redid the layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements in comment mentions:
New layout, decreased the size of the mentions menu
Added a new route for comment mentions search. the current query brought all emails from all users in the search. This was considered a secutiry flaw
There was a request on each key typed after adding a mention. The best option for now was to removed space option in the mention (user) search