Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Conversation

@LMJ-19
Copy link

@LMJ-19 LMJ-19 commented Jun 22, 2020

In this pull request I performed the updates suggested in #18 and #19.

A small note: the alias open='xdg-open' did not work on my and Martijn's Linux Ubuntu version, since openwas still referring to/bin/openand notxdg-open`. However, we think that users can find the generated html manually as well, so it is not that much of a problem.

@LMJ-19 LMJ-19 requested a review from AckslD June 22, 2020 19:12
@AckslD
Copy link
Member

AckslD commented Jun 23, 2020

Nice @LMJ-19, I think you also mentioned to make it more clear in the README that one can set the environment variables for make install now that the error won't show up right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants