Skip to content

Commit d2d0016

Browse files
author
Chris Hold
committed
Fix 90 deg offset
1 parent 34e47d3 commit d2d0016

9 files changed

+16
-12
lines changed

src/gui/qopenglplotter.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,9 @@ void ssr::QOpenGLPlotter::_draw_reference()
383383
glTranslatef(0.03f, -0.03f, 0.0f);
384384

385385
// rotate according to reference offset position
386-
glRotatef(90.0f + _scene.get_reference_offset().orientation.azimuth, 0.0f, 0.0f, 1.0f);
386+
glRotatef(_scene.get_reference().orientation.azimuth +
387+
_scene.get_reference_offset().orientation.azimuth,
388+
0.0f, 0.0f, 1.0f);
387389

388390
glBindTexture(GL_TEXTURE_2D, _listener_shadow_texture);
389391

@@ -397,7 +399,9 @@ void ssr::QOpenGLPlotter::_draw_reference()
397399
glPopMatrix();
398400

399401
// rotate according to reference offset position
400-
glRotatef(90.0f + _scene.get_reference_offset().orientation.azimuth, 0.0f, 0.0f, 1.0f);
402+
glRotatef(_scene.get_reference().orientation.azimuth +
403+
_scene.get_reference_offset().orientation.azimuth,
404+
0.0f, 0.0f, 1.0f);
401405

402406
glBindTexture(GL_TEXTURE_2D, _listener_texture);
403407

src/gui/quserinterface.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,8 +993,8 @@ void ssr::QUserInterface::mouseMoveEvent(QMouseEvent *event)
993993
// previous position relative to relative position offset
994994
prev_mouse_pos -= _scene.get_reference_offset().position;
995995

996-
_controller.take_control()->reference_offset_rotation(_scene.get_reference_offset().rotate(90.0f).orientation +
997-
(mouse_pos.orientation() - prev_mouse_pos.orientation()));
996+
_controller.take_control()->reference_offset_rotation(_scene.get_reference_offset().orientation +
997+
(mouse_pos.orientation() - prev_mouse_pos.orientation()));
998998

999999
} // else if
10001000

src/legacy_scene.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ class LegacyScene : public api::SceneControlEvents
388388
void reference_offset_rotation(const Rot& rotation) override
389389
{
390390
Orientation orientation(rotation);
391-
orientation.azimuth -= 90.0f; // Undo angle conversion offset
391+
// orientation.azimuth -= 90.0f; // Undo angle conversion offset
392392
_reference_offset.orientation = orientation;
393393
}
394394

src/rendersubscriber.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class RenderSubscriber : public api::BundleEvents
186186
Orientation orientation{rot};
187187
// For backwards compatibility, 90 degrees are added when converting to
188188
// Orientation. This, however, should not be done for the reference offset.
189-
orientation.azimuth -= 90.0f;
189+
// orientation.azimuth -= 90.0f;
190190
_renderer.state.reference_offset_orientation = orientation;
191191
_reference_offset_rotation = rot;
192192
}

src/trackerintersense.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,12 @@ void* ssr::TrackerInterSense::thread(void *arg)
193193
ISD_GetTrackingData(_tracker_h, &tracker_data);
194194
_controller.take_control()->reference_offset_rotation(
195195
Orientation(-tracker_data.Station[0].Euler[0]
196-
+ 90.0f + 90.0f));
196+
+ 90.0f));
197197
#else
198198
ISD_GetData(_tracker_h, &tracker_data);
199199
_controller.take_control()->reference_offset_rotation(
200200
Orientation(-static_cast<float>(tracker_data.Station[0].Orientation[0])
201-
+ 90.0f + 90.0f));
201+
+ 90.0f));
202202
#endif
203203

204204
// wait a bit

src/trackerpolhemus.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ ssr::TrackerPolhemus::thread(void *arg)
301301
>> _current_data.roll;
302302

303303
_controller.take_control()->reference_offset_rotation(
304-
Orientation(-_current_data.azimuth + _az_corr + 90.0f));
304+
Orientation(-_current_data.azimuth + _az_corr));
305305
};
306306
return arg;
307307
}

src/trackerrazor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ ssr::TrackerRazor::TrackerRazor(api::Publisher& controller
3535
: Tracker()
3636
, _controller(controller)
3737
, _current_azimuth(0.0f)
38-
, _az_corr(90.0f)
38+
, _az_corr(0.0f)
3939
, _init_az_corr(true)
4040
, _tracker(nullptr)
4141
{

src/trackerrazor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class TrackerRazor : public Tracker
7474
_init_az_corr = false;
7575
}
7676
_controller.take_control()->reference_offset_rotation(
77-
Orientation(-_current_azimuth + _az_corr + 90.0f));
77+
Orientation(-_current_azimuth + _az_corr));
7878
}
7979
void on_error(const std::string &msg) { ERROR("Razor AHRS: " << msg); }
8080

src/trackervrpn.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,5 +142,5 @@ ssr::TrackerVrpn::vrpn_change_handler(const vrpn_TRACKERCB t)
142142

143143
_current_azimuth = azi;
144144
_controller.take_control()->reference_offset_rotation(
145-
Orientation(-azi + _az_corr + 90.0f));
145+
Orientation(-azi + _az_corr));
146146
}

0 commit comments

Comments
 (0)