Failures collection format

[quantumwebco]

The failures collection is formatted in an odd way

If there is, for example, an email and an age column and the rules are valid email and age > 0, the errors don't come together like

[
    [
        'row'    => 1,
        'errors' => [
            [
                'attribute' => 'email',
                'message'   => 'You must specify a valid email address',
            ],
            [
                'attribute' => 'age',
                'message'   => 'The age field must have a minimum value of 1',
            ],
        ],
        'values' => [
            [
                'age'   => 0,
                'email' => 'not*@*valid.email',
            ],
        ],
    ],
]

Currently they all come separately, with an item for each attribute that errored and grouped by the validation. So I get a list of all the rows that failed email validation, then a list of all the rows that failed age validation. Which means rows that failed on more than one rule are duplicated just with a different error message and not grouped together

Can kind of get around it by groupBy(fn($item) => $item->row()) which would be nicer if row wasn't a protected property so can just do groupBy('row'), and then manipulating and flattening etc.

Do I just have a weird use case or would others also prefer the collection formatted as above?

[patrickbrouwers]

I think it would be fine to make row a public property, anything else would be a breaking change. Adding a convenience method for this would be fine too.

[quantumwebco]

Yeah I thought row could be public, shall I PR that? But understand changing the format would be a breaking change. I've worked around by grouping by row in the constructor and using WithMapping to transform the collection

Thanks!

[patrickbrouwers]

Yep PR is fine