Skip to content

Commit 5d19e8d

Browse files
committed
all actions params with underscores
1 parent 4097d64 commit 5d19e8d

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

.github/workflows/python_checks.yml

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ on:
5050
The list of directories to run pytest on. Space-seperated
5151
required: true
5252
type: string
53-
coverage-package:
53+
coverage_package:
5454
description: The names of the Python package to get coverage for
5555
required: true
5656
type: string
57-
flake8-packages:
57+
flake8_packages:
5858
description: The names of the Python packages to run flake8 on.
5959
required: true
6060
type: string
@@ -79,11 +79,11 @@ on:
7979
default: global_strict
8080
# global_relaxed and global_strict will use files in support scripts
8181
# Any other value will be looked for in the calling repository
82-
pylint-packages:
82+
pylint_packages:
8383
description: The names of the Python packages to run flake8 on.
8484
required: true
8585
type: string
86-
pylint-disable:
86+
pylint_disable:
8787
description: The pylint messages/categories to disable
8888
required: false
8989
type: string
@@ -93,14 +93,14 @@ on:
9393
required: false
9494
type: string
9595
default: "31" # Action fails on any message
96-
mypy-full_packages:
96+
mypy_full_packages:
9797
description: >
9898
The names of the Python packages to run full mypy on.
9999
These are run in --disallow-untyped-defs mode
100100
required: false
101101
type: string
102102
default: ''
103-
mypy-packages:
103+
mypy_packages:
104104
description: >
105105
The names of Python packages to run simple mypy on.
106106
These are run in without --disallow-untyped-defs
@@ -127,7 +127,7 @@ on:
127127
required: false
128128
type: string
129129
default: "doc/source"
130-
run_cff-validator:
130+
run_cff_validator:
131131
description: Flag to say if cff-validator should be run
132132
required: false
133133
type: string
@@ -172,38 +172,38 @@ jobs:
172172
directory: ${{ inputs.sphinx_directory }}
173173

174174
- name: Validate CITATION.cff
175-
if: ${{ inputs.run_cff-validator == 'true' }}
175+
if: ${{ inputs.run_cff_validator == 'true' }}
176176
uses: dieghernan/cff-validator@main
177177
with:
178178
install-r: true
179179

180180
- name: Lint with flake8
181-
run: flake8 ${{ inputs.flake8-packages }}
181+
run: flake8 ${{ inputs.flake8_packages }}
182182

183183
- name: Lint with pylint
184184
uses: SpiNNakerManchester/SupportScripts/actions/pylint@main
185185
with:
186-
package: ${{ inputs.pylint-packages }}
187-
disable: ${{ inputs.pylint-disable }}
186+
package: ${{ inputs.pylint_packages }}
187+
disable: ${{ inputs.pylint_disable }}
188188
exitcheck: ${{ inputs.pylint_exitcheck }}
189189
rcfile: ${{ inputs.rcfile }}
190190
language: en_GB
191191

192192
- name: Lint with mypy
193-
if: ${{ inputs.mypy-packages != ''}}
194-
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy-packages }}
193+
if: ${{ inputs.mypy_packages != ''}}
194+
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy_packages }}
195195

196196
- name: Lint with mypy using disallow-untyped-def
197-
if: ${{ inputs.mypy-full-packages != ''}}
198-
run: mypy --python-version ${{ matrix.python-version }} --disallow-untyped-defs ${{ inputs.mypy-full-packages }}
197+
if: ${{ inputs.mypy_full_packages != ''}}
198+
run: mypy --python-version ${{ matrix.python-version }} --disallow-untyped-defs ${{ inputs.mypy_full_packages }}
199199

200200
- name: Test with pytest
201201
if: ${{ inputs.test_directories != ''}}
202202
uses: SpiNNakerManchester/SupportScripts/actions/pytest@main
203203
with:
204204
tests: ${{ inputs.test_directories }}
205-
coverage: ${{ matrix.coverage == 'coverage' && inputs.coverage-package != '' }}
206-
cover-packages: ${{ inputs.coverage-package }}
205+
coverage: ${{ matrix.coverage == 'coverage' && inputs.coverage_package != '' }}
206+
cover-packages: ${{ inputs.coverage_package }}
207207
coveralls-token: ${{ secrets.GITHUB_TOKEN }}
208208
env:
209209
SPALLOC_USER: ${{ secrets.SPALLOC_USER }}
@@ -249,25 +249,25 @@ jobs:
249249

250250
- name: Lint with flake8
251251
if: ${{ matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true' }}
252-
run: flake8 ${{ inputs.flake8-packages }}
252+
run: flake8 ${{ inputs.flake8_packages }}
253253

254254
- name: Lint with pylint
255255
if: ${{ matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true' }}
256256
uses: SpiNNakerManchester/SupportScripts/actions/pylint@main
257257
with:
258-
package: ${{ inputs.pylint-packages }}
259-
disable: ${{ inputs.pylint-disable }}
258+
package: ${{ inputs.pylint_packages }}
259+
disable: ${{ inputs.pylint_disable }}
260260
exitcheck: ${{ inputs.pylint_exitcheck }}
261261
rcfile: ${{ inputs.rcfile }}
262262
language: en_GB
263263

264264
- name: Lint with mypy
265-
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy-packages != '' }}
266-
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy-packages }}
265+
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy_packages != '' }}
266+
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy_packages }}
267267

268268
- name: Lint with mypy using disallow-untyped-def
269-
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy-full-packages != '' }}
270-
run: mypy --python-version ${{ matrix.python-version }} --disallow-untyped-defs ${{ inputs.mypy-full-packages }}
269+
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.mypy_full_packages != '' }}
270+
run: mypy --python-version ${{ matrix.python-version }} --disallow-untyped-defs ${{ inputs.mypy_full_packages }}
271271

272272
- name: Test with pytest
273273
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check_prereleases == 'true') && inputs.test_directories != ''}}

0 commit comments

Comments
 (0)