Fix tests

Author: alejoe91

src/spikeinterface/core/sorting_tools.py

@@ -940,10 +940,9 @@ def remap_unit_indices_in_vector(vector, all_old_unit_ids, all_new_unit_ids, kee
             continue
         if old_unit_id in all_new_unit_ids:
             new_unit_index = all_new_unit_ids.index(old_unit_id)
-            if new_unit_index[new_unit_index]:
-                mapping[old_unit_ind] = new_unit_index
-                keep[old_unit_ind] = True
-    keep_mask = vector["unit_index"][keep]
+            mapping[old_unit_ind] = new_unit_index
+            keep[old_unit_ind] = True
+    keep_mask = keep[vector["unit_index"]]
     new_vector = vector[keep_mask]
     new_vector["unit_index"] = mapping[new_vector["unit_index"]]
 

src/spikeinterface/postprocessing/valid_unit_periods.py

@@ -418,16 +418,16 @@ def _compute_valid_periods(self, sorting_analyzer, unit_ids=None, **job_kwargs):
             all_fps[np.isnan(all_fps)] = 1.0
             all_fns[np.isnan(all_fns)] = 1.0
 
-            good_period_mask = (all_fps < self.params["fp_threshold"]) & (all_fns < self.params["fn_threshold"])
-            good_periods = all_periods[good_period_mask]
+            valid_period_mask = (all_fps < self.params["fp_threshold"]) & (all_fns < self.params["fn_threshold"])
+            valid_unit_periods = all_periods[valid_period_mask]
 
             # Combine with user-defined periods if provided
             if self.params["method"] == "combined":
                 user_defined_periods = self.user_defined_periods
                 valid_unit_periods = np.concatenate((valid_unit_periods, user_defined_periods), axis=0)
 
             # Sort good periods on segment_index, unit_index, start_sample_index
-            valid_unit_periods, _ = self._sort_periods(good_periods)
+            valid_unit_periods, _ = self._sort_periods(valid_unit_periods)
             valid_unit_periods = merge_overlapping_periods_across_units_and_segments(valid_unit_periods)
 
             # Remove good periods that are too short