Double check highpass_spatial_filter implementation with `ibl-neuropixel`

[alejoe91]

@oliche

[oliche]

Yes there seems to be an issue with the SI implementation as the quality is degraded:

Expected from ibl-neuropixel:

Actual from spike-interface

Let me dig into SI code to find the discrepancy source (missing cast to float ? AGC ? )

[JoeZiminski]

Thanks for looking into this @oliche, it would be good to hear what you find. The two implementations are directly compared here in case this is useful, there must be some case not covered by the test data.

[oliche]

Here is a minimal example to reproduce:

# uv pip install s3fs
# sudo apt-get install libwavpack-dev
#  uv pip install wavpack-numcodecs
import spikeinterface.full as si
import spikeinterface.preprocessing as spre
s3_path = "s3://aind-open-data/ecephys_813047_2025-10-20_16-35-28/ecephys/ecephys_compressed/experiment1_Record Node 101#Neuropix-PXI-100.ProbeA-AP.zarr"
recording = si.load(s3_path)
recroding = spre.astype(recording, "float")
recording_ps = si.phase_shift(recording)
recording_hp = si.highpass_filter(recording_ps)
recording_cmr = si.common_reference(recording_hp)
recording_hps = si.highpass_spatial_filter(recording_hp)
rec_dict = dict(hp=recording_hp, cmr=recording_cmr, hps=recording_hps)

# %% uv pip install ibl-neuropixel
import neuropixel
import numpy as np
import ibldsp.voltage
fs = recording.sampling_frequency
s0, s1 = int(1723.5 * fs), int(1724 * fs)
raw = recording.get_traces(start_frame=s0, end_frame=s1).astype(np.float32).T * neuropixel.S2V_AP
cmr_si = recording_cmr.get_traces(start_frame=s0, end_frame=s1).astype(np.float32).T * neuropixel.S2V_AP
destripe_si = recording_hps.get_traces(start_frame=s0, end_frame=s1).astype(np.float32).T * neuropixel.S2V_AP

destripe = ibldsp.voltage.destripe(raw, fs=fs, neuropixel_version=1)

# %% uv pip install viewephys
from viewephys.gui import viewephys
eqc = {}
eqc['raw'] = viewephys(raw, fs=fs, title='raw')
eqc['destripe'] = viewephys(destripe, fs=fs, title='destripe')
eqc['destripe_si'] = viewephys(destripe_si, fs=fs, title='destripe_si')
eqc['cmr_si'] = viewephys(destripe_si, fs=fs, title='cmr_si')

[oliche]

PR here: #4286