Merge pull request #167 from SpineEventEngine/add-storage-tests

Add and refactor storage tests

Author: Alexander Litus

server/src/test/java/org/spine3/server/storage/AbstractStorageShould.java

@@ -20,6 +20,7 @@
 
 package org.spine3.server.storage;
 
+import com.google.common.base.Throwables;
 import com.google.protobuf.Message;
 import org.junit.After;
 import org.junit.Before;
@@ -68,9 +69,9 @@ public void tearDownAbstractStorageTest() {
     protected abstract I newId();
 
     /**
-     * Closes the storage.
+     * Closes the storage and propagates an exception if any occurs.
      *
-     * @throws RuntimeException which wraps the primary one if occurs
+     * @see Throwables#propagate(Throwable)
      */
     protected void close(AbstractStorage storage) {
         if (storage.isOpen()) {
@@ -82,6 +83,27 @@ protected void close(AbstractStorage storage) {
         }
     }
 
+    /** Closes the storage and fails the test if any exception occurs. */
+    protected void closeAndFailIfException(AbstractStorage<I, R> storage) {
+        try {
+            storage.close();
+        } catch (Exception e) {
+            //noinspection CallToPrintStackTrace
+            e.printStackTrace();
+            fail("An unexpected exception: " + e.getClass() + "; " + e.getMessage());
+        }
+    }
+
+    /** Writes a record, reads it and asserts it is the same as the expected one. */
+    protected void writeAndReadRecordTest(I id) {
+        final R expected = newStorageRecord();
+        storage.write(id, expected);
+
+        final R actual = storage.read(id);
+
+        assertEquals(expected, actual);
+    }
+
     @Test
     public void return_default_record_instance_if_no_record_with_such_id() {
         final R record = storage.read(newId());
@@ -123,25 +145,11 @@ public void rewrite_record_if_write_by_the_same_id() {
         writeAndReadRecordTest(id);
     }
 
-    protected void writeAndReadRecordTest(I id) {
-        final R expected = newStorageRecord();
-        storage.write(id, expected);
-
-        final R actual = storage.read(id);
-
-        assertEquals(expected, actual);
-    }
-
-    @Test
-    public void throw_exception_if_it_is_closed_on_check() throws Exception {
-        storage.close();
+    @Test(expected = IllegalStateException.class)
+    public void assure_it_is_closed() throws Exception {
+        closeAndFailIfException(storage);
 
-        try {
-            storage.checkNotClosed();
-            fail("An exception must be thrown.");
-        } catch (IllegalStateException e) {
-            // is OK because it is closed
-        }
+        storage.checkNotClosed();
     }
 
     @Test
@@ -173,27 +181,24 @@ public void return_false_if_it_not_closed() throws Exception {
         assertFalse(storage.isClosed());
     }
 
-    @Test
-    public void close_itself_and_throw_exception_if_read_then() throws Exception {
-        storage.close();
+    @Test(expected = IllegalStateException.class)
+    public void close_itself_and_throw_exception_if_read_after() throws Exception {
+        closeAndFailIfException(storage);
 
-        try {
-            storage.read(newId());
-            fail("An exception must be thrown on attempt to read.");
-        } catch (IllegalStateException e) {
-            // is OK because storage is closed
-        }
+        storage.read(newId());
     }
 
-    @Test
-    public void close_itself_and_throw_exception_if_write_then() throws Exception {
-        storage.close();
+    @Test(expected = IllegalStateException.class)
+    public void close_itself_and_throw_exception_if_write_after() throws Exception {
+        closeAndFailIfException(storage);
 
-        try {
-            storage.write(newId(), newStorageRecord());
-            fail("An exception must be thrown on attempt to write.");
-        } catch (IllegalStateException e) {
-            // is OK because storage is closed
-        }
+        storage.write(newId(), newStorageRecord());
+    }
+
+    @Test(expected = IllegalStateException.class)
+    public void throw_exception_if_close_twice() {
+        closeAndFailIfException(storage);
+
+        storage.read(newId());
     }
 }