Merge branch 'master' into proto-messages-validation

Conflicts:
	client/src/test/java/org/spine3/base/CommandsShould.java

Author: Alexander Litus

.idea/inspectionProfiles/Project_Default.xml

@@ -10,6 +10,7 @@ buildscript {
 
 dependencies {
     compile group: 'io.grpc', name: 'grpc-all', version: '0.13.1'
+    testCompile project (path: ":testutil", configuration: 'testArtifacts')
 }
 
 apply plugin: 'org.spine3.tools.protobuf-plugin';

client/build.gradle

@@ -18,10 +18,11 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-package org.spine3.test;
+package org.spine3.client.test;
 
 import com.google.protobuf.Message;
 import com.google.protobuf.Timestamp;
+import org.spine3.Internal;
 import org.spine3.base.Command;
 import org.spine3.base.CommandContext;
 import org.spine3.base.UserId;
@@ -35,6 +36,7 @@
  *
  * @author Alexaner Yevsyukov
  */
+@Internal
 public class TestCommandFactory extends CommandFactory {
 
     public static TestCommandFactory newInstance(String actor, ZoneOffset zoneOffset) {

…/org/spine3/test/TestCommandFactory.java …ine3/client/test/TestCommandFactory.javaclient/src/test/java/org/spine3/test/TestCommandFactory.java renamed to client/src/main/java/org/spine3/client/test/TestCommandFactory.java client/src/test/java/org/spine3/test/TestCommandFactory.java renamed to client/src/main/java/org/spine3/client/test/TestCommandFactory.java

@@ -33,7 +33,7 @@
 import static com.google.common.base.Throwables.propagate;
 
 /**
- * Utility class for working with message fields.
+ * Abstract base for classes working with message fields.
  *
  * @author Mikhail Mikhaylov
  * @author Alexander Yevsyukov
@@ -59,6 +59,11 @@ public abstract class MessageField {
      */
     private static final Map<Class<? extends Message>, Method> accessors = Maps.newConcurrentMap();
 
+    /**
+     * Creates an instance for the field with the passed number.
+     *
+     * @param index the zero-based index of the field
+     */
     protected MessageField(int index) {
         this.index = index;
     }

client/src/main/java/org/spine3/protobuf/MessageField.java

@@ -28,9 +28,9 @@
 import com.google.protobuf.Message;
 import com.google.protobuf.StringValue;
 import org.junit.Test;
+import org.spine3.client.test.TestCommandFactory;
 import org.spine3.test.RunTest;
 import org.spine3.test.TestCommand;
-import org.spine3.test.TestCommandFactory;
 import org.spine3.type.TypeName;
 
 import java.util.ArrayList;

client/src/test/java/org/spine3/base/CommandsShould.java

@@ -24,6 +24,7 @@
 
 import static org.junit.Assert.assertEquals;
 
+@SuppressWarnings("InstanceMethodNamingConvention")
 public class ErrorsShould {
 
     @Test

client/src/test/java/org/spine3/base/ErrorsShould.java

@@ -28,8 +28,8 @@
 import org.junit.Test;
 import org.spine3.base.Command;
 import org.spine3.client.CommandFactory;
+import org.spine3.client.test.TestCommandFactory;
 import org.spine3.test.RunTest;
-import org.spine3.test.TestCommandFactory;
 
 import static org.junit.Assert.*;
 import static org.spine3.protobuf.Values.newStringValue;

client/src/test/java/org/spine3/test/Tests.java

@@ -25,6 +25,7 @@ option java_package="org.spine3.test";
 option java_multiple_files = true;
 option java_outer_classname = "TestCommands";
 
+// A test command to run a test by the method name.
 message RunTest {
     string method_name = 1;
 }