Document thread-safe connection event usage #1015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosemister
requested changes
Oct 13, 2024
Member
mosemister
left a comment
mosemister
left a comment
There was a problem hiding this comment.
Only done a quick scan with one comment so far. More may come when i have the time to properly load up your branch
| Best Practices | ||
| ============== | ||
| Due to the nature of connection events being asynchronously, plugin developers **must** use thread-safe | ||
| collections when storing, accessing and mutating related data. |
Member
There was a problem hiding this comment.
Due to many people not knowing there is thread safe collections, could we have it link to here (the official docs on concurrent collections). I know you have a example below, just a link to give more examples)
https://docs.oracle.com/javase/tutorial/essential/concurrency/collections.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.