Merge pull request #7 from Springest/fix/empty_ab_file

Fixes #6

Author: Peter de Ruijter

example/config/ab_panel.yml

@@ -1,10 +1,10 @@
 my_experiment:
-  - condition_b
-  - condition_c
+  condition_b: 1
+  condition_c: 1
 
 another_experiment:
-  - foo
-  - bar
+  foo: 1
+  bar: 1
 
 third_experiment:
-  - boo
+  boo: 1

lib/ab_panel/config.rb

@@ -7,6 +7,7 @@ def initialize
     end
 
     def experiments
+      return {} if !settings
       settings.keys.map(&:to_sym)
     end
 
@@ -21,9 +22,9 @@ def weights(experiment)
     end
 
     def settings
-      @settings ||= YAML.load(
-        ERB.new(File.read(File.join(Rails.root, 'config', 'ab_panel.yml'))).result)
-        .symbolize_keys
+      return @settings if defined?(@settings)
+      results = YAML.load(ERB.new(File.read(File.join(Rails.root, 'config', 'ab_panel.yml'))).result)
+      @settings = results ? results.symbolize_keys : nil
     end
   end
 end

lib/ab_panel/version.rb

@@ -1,3 +1,3 @@
 module AbPanel
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

spec/ab_panel/config_spec.rb

@@ -2,18 +2,34 @@
 
 describe AbPanel::Config do
   let(:config) { AbPanel::Config.new }
-  before do
-    AbPanel::Config.any_instance.stub(:settings) { { exp1: { scenario1: 25, scenario2: 75 } } }
-  end
+  context "config" do
+    before do
+      AbPanel::Config.any_instance.stub(:settings) { { exp1: { scenario1: 25, scenario2: 75 } } }
+    end
 
-  describe '.experiments' do
-    subject { config.experiments }
-    it { should =~ [:exp1] }
-  end
+    describe '.experiments' do
+      subject { config.experiments }
+      it { should =~ [:exp1] }
+    end
 
-  describe '.weights' do
-    subject { config.weights('exp1') }
+    describe '.weights' do
+      subject { config.weights('exp1') }
+
+      it { should =~ [75.0, 25.0] }
+    end
+  end
+  context "empty config" do
+    before do
+      YAML.stub(:load) { false }
+    end
+    describe ".settings" do
+      subject { config.settings }
+      it { should eq nil }
+    end
 
-    it { should =~ [75.0, 25.0] }
+    describe ".experiments" do
+      subject { config.experiments }
+      it { should == {} }
+    end
   end
 end