Skip to content

Commit 613c768

Browse files
committed
📝 :: Loading 화면 로직 변경
1 parent 8ff64da commit 613c768

File tree

4 files changed

+18
-34
lines changed

4 files changed

+18
-34
lines changed

feature/mission/src/main/java/com/stackkowledge/mission/EntireMissionScreen.kt

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.stackkowledge.mission
22

3-
import android.util.Log
43
import androidx.activity.ComponentActivity
54
import androidx.compose.foundation.background
65
import androidx.compose.foundation.layout.Box
@@ -21,10 +20,9 @@ import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
2120
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
2221
import com.stackknowledge.design_system.theme.StackKnowledgeAndroidTheme
2322
import com.stackkowledge.mission.component.EntireMissionList
24-
import com.stackkowledge.mission.viewmodel.uistate.GetMissionUiState
2523
import com.stackkowledge.mission.viewmodel.MissionViewModel
24+
import com.stackkowledge.mission.viewmodel.uistate.GetMissionUiState
2625
import enumdatatype.Authority
27-
import java.util.UUID
2826

2927
@Composable
3028
internal fun EntireMissionRoute(
@@ -68,14 +66,10 @@ private fun EntireMissionScreen(
6866
.fillMaxSize()
6967
) {
7068
StackKnowledgeTopBar()
71-
if (missionUiState is GetMissionUiState.Success) {
72-
val mission = missionUiState.missionResponseModel
73-
EntireMissionList(
74-
getMissionUiState = missionUiState,
75-
missionList = mission,
76-
onClick = { onItemClick(it) },
77-
)
78-
}
69+
EntireMissionList(
70+
getMissionUiState = missionUiState,
71+
onClick = { onItemClick(it) },
72+
)
7973
}
8074
Box(
8175
modifier = Modifier.align(alignment = Alignment.BottomCenter),
@@ -89,5 +83,4 @@ private fun EntireMissionScreen(
8983
}
9084
}
9185
}
92-
Log.e("testt", missionUiState.toString())
9386
}

feature/mission/src/main/java/com/stackkowledge/mission/component/EntireMissionList.kt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import remote.response.mission.MissionResponseModel
2929
fun EntireMissionList(
3030
modifier: Modifier = Modifier,
3131
getMissionUiState: GetMissionUiState,
32-
missionList: List<MissionResponseModel>,
3332
onClick: (String) -> Unit,
3433
) {
3534
StackKnowledgeAndroidTheme { colors, _ ->
@@ -41,6 +40,7 @@ fun EntireMissionList(
4140
) {
4241
when (getMissionUiState) {
4342
is GetMissionUiState.Success -> {
43+
val missionList = getMissionUiState.missionResponseModel
4444
LazyVerticalGrid(
4545
modifier = Modifier
4646
.fillMaxSize()
@@ -51,16 +51,15 @@ fun EntireMissionList(
5151
top = 16.dp,
5252
),
5353
) {
54-
itemsIndexed(missionList) { _, item ->
55-
54+
items(missionList.size) { index ->
5655
Box(
5756
contentAlignment = Alignment.Center
5857
) {
5958
EntireMissionItem(
60-
name = item.user.name,
61-
title = item.title,
62-
point = item.point,
63-
onClick = { onClick(item.id) },
59+
name = missionList[index].user.name,
60+
title = missionList[index].title,
61+
point = missionList[index].point,
62+
onClick = { onClick(missionList[index].id) },
6463
)
6564
}
6665

feature/score-mission/src/main/java/com/stackknowledge/score_mission/SolvedMissionScreen.kt

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
package com.stackknowledge.score_mission
22

3-
import android.util.Log
43
import androidx.activity.ComponentActivity
54
import androidx.compose.foundation.background
65
import androidx.compose.foundation.layout.Box
76
import androidx.compose.foundation.layout.Column
87
import androidx.compose.foundation.layout.fillMaxSize
9-
import androidx.compose.material3.Surface
108
import androidx.compose.runtime.Composable
119
import androidx.compose.runtime.LaunchedEffect
1210
import androidx.compose.runtime.getValue
@@ -16,7 +14,6 @@ import androidx.compose.runtime.setValue
1614
import androidx.compose.ui.Alignment
1715
import androidx.compose.ui.Modifier
1816
import androidx.compose.ui.platform.LocalContext
19-
import androidx.compose.ui.tooling.preview.Preview
2017
import androidx.hilt.navigation.compose.hiltViewModel
2118
import androidx.lifecycle.compose.collectAsStateWithLifecycle
2219
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
@@ -67,16 +64,11 @@ private fun SolvedMissionScreen(
6764
.fillMaxSize()
6865
) {
6966
StackKnowledgeTopBar()
70-
if (scoreMissionListUiState is GetScoreMissionListUiState.Success) {
71-
val scoreMission = scoreMissionListUiState.getSolveMissionResponseModel
72-
SolvedMissionList(
73-
getScoreMissionListUiState = scoreMissionListUiState,
74-
scoreMission = scoreMission,
75-
onClick = { onItemClick() },
76-
intentId = { intentId(it) }
77-
)
78-
Log.e("ScoreMissionListScreen", scoreMission.toString())
79-
}
67+
SolvedMissionList(
68+
getScoreMissionListUiState = scoreMissionListUiState,
69+
onClick = { onItemClick() },
70+
intentId = { intentId(it) }
71+
)
8072
}
8173
Box(
8274
modifier = Modifier.align(alignment = Alignment.BottomCenter),

feature/score-mission/src/main/java/com/stackknowledge/score_mission/component/SolvedMissionList.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import java.util.UUID
3131
fun SolvedMissionList(
3232
modifier: Modifier = Modifier,
3333
getScoreMissionListUiState: GetScoreMissionListUiState,
34-
scoreMission: GetSolveMissionResponseModel,
3534
onClick: () -> Unit,
3635
intentId: (String) -> Unit,
3736
) {
@@ -45,6 +44,7 @@ fun SolvedMissionList(
4544
) {
4645
when (getScoreMissionListUiState) {
4746
is GetScoreMissionListUiState.Success -> {
47+
val scoreMissionList = getScoreMissionListUiState.getSolveMissionResponseModel
4848
LazyVerticalGrid(
4949
modifier = modifier.fillMaxSize(),
5050
columns = GridCells.Fixed(2),
@@ -53,7 +53,7 @@ fun SolvedMissionList(
5353
top = 16.dp,
5454
),
5555
) {
56-
itemsIndexed(scoreMission.response) { _, item ->
56+
itemsIndexed(scoreMissionList.response) { _, item ->
5757
Box(
5858
contentAlignment = Alignment.Center
5959
) {

0 commit comments

Comments
 (0)